[Go] Add Iterative tree walker in go#3740
Merged
Conversation
Signed-off-by: Rishabh Arya <rishabh.aryain@gmail.com>
Signed-off-by: Rishabh Arya <rishabh.aryain@gmail.com>
rishabh-arya95
force-pushed
the
go-iterative-walker
branch
from
7d259d2 to
9c480dc
Compare
Member
|
Now that I have merged the update to the Go Target made by @jimidle maybe you guys can take another look to ensure it is compatible. |
Collaborator
|
I will take a look at this after 4.11.0 is released. Right now, I do not know if anyone has attempted this, but it is probably best done with generics and current tree stuff does not use generics... yet. |
Collaborator
|
@parrt Would you please assign this to me, or label it with Go. |
Collaborator
|
This code now needs to be moved in to the /v4 version of the go runtime. I have not tried this and there are no tests, but as it is a new file, it seems safe enough. We can merge this one and I can copy it to the v4 version. |
Member
|
@jimidle so I should merge this one and then you will copy it to v4? |
Collaborator
|
Yes. Let’s do that. The OP hasn’t resubmitted. It’s a small addition, so I
can just do it.
…On Fri, Sep 16, 2022 at 07:59 Terence Parr ***@***.***> wrote:
@jimidle <https://github.com/jimidle> so I should merge this one and then
you will copy it to v4?
—
Reply to this email directly, view it on GitHub
<#3740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7TMEDSQO3AVPPEYPVN5DV6OZ7RANCNFSM5X433ZKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
done @jimidle ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the iterative tree walker implementation for GO, inspired by the java iterative walker
#1231