Modernize CMakeLists.txt and a few Windows specific fixes#3663
Merged
Modernize CMakeLists.txt and a few Windows specific fixes#3663
Conversation
* Upgraded to minimum version 3.15 (was 3.14) * Use CMAKE_MSVC_RUNTIME_LIBRARY to configure CRT * Use target_compile_definitions to configure definitions so they can selectively be propagated upward (ANTLR4CPP_EXPORTS & ANTLR4CPP_STATIC needed to be propagated upwards) * Handle CRT requirement for test correctly (gtest configuration should depend on WITH_STATIC_CRT) * Don't change the default CMake output directory. With multiple configurations CMake doesn't trigger a build when the configuration is switched resulting in link errors (debug linking against release or vice-versa). * Rename the static pdb file the same as the library (this was a conflict with both static and shared attempting to write to the same pdb file) * Fixed x86 targets (definition of MurmurHash::update was missing) * Updated CMakeSettings.json to build within project directory hierarchy rather than in user profile directory (the latter used to be VS default) Signed-off-by: HS <hs@apotell.com>
jcking
approved these changes
Apr 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize CMakeLists.txt and a few Windows specific fixes
Signed-off-by: HS hs@apotell.com