keep getSerializedATNSegmentLimit at max int #3538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated code with
getSerializedATNSegmentLimit()set to 80 (current dev value) and max int. Here is diff with C++ target:On the left we see small segments but it's unnecessary and wasteful compared to the big static array on right. This PR makes it look like right side. Only Java really needs this. Targets are free to ignore
getSerializedATNSegmentLimit()as JavaScript does. I.e., JavaScript always looks like right side of pic.@KvanTTT @marcospassos @jcking @ericvergnaud @mike-lischke Any concerns?