Conversation
KvanTTT
force-pushed
the
caseInsensitiveLexerCommand
branch
from
b614644 to
d763a26
Compare
KvanTTT
force-pushed
the
caseInsensitiveLexerCommand
branch
from
d763a26 to
214a45b
Compare
KvanTTT
force-pushed
the
caseInsensitiveLexerCommand
branch
2 times, most recently
from
2ee4d10 to
e8771c1
Compare
KvanTTT
changed the title
|
|
||
| ## Lexer Rule Options | ||
|
|
||
| ### caseInsensitive |
There was a problem hiding this comment.
I'm not sure about the best location for caseInsensitive lexer rule option. Maybe it makes sense to move to https://github.com/antlr/antlr4/blob/master/doc/options.md#rule-options
There was a problem hiding this comment.
maybe a reference in one spot to the other?
There was a problem hiding this comment.
Done, I made a reference in options.md: https://github.com/antlr/antlr4/pull/3437/files#diff-6420f854d462e04fe86b98f8bd495e3ec6f42f94121c39a37d228ba74ea91052R114
| public static final Set<String> parserOptions = new HashSet<String>(); | ||
| public static final String caseInsensitiveOptionName = "caseInsensitive"; | ||
|
|
||
| public static final Set<String> ParserOptions = new HashSet<String>(); |
There was a problem hiding this comment.
I think for consistency we should keep this as initial lowercase, just like the others.
There was a problem hiding this comment.
I've encountered a mess with lower/UPPER case identifiers: https://github.com/antlr/antlr4/blob/master/tool/src/org/antlr/v4/tool/Grammar.java#L89-L95 So, you think it's better to use lower case for all options, do you?
There was a problem hiding this comment.
well I reserve the first capital letter for types like classes... at the very least we should be consistent at this point
|
sorry.. I messed up the build of this PR when I tried to resolve the conflict. I missed: in the lexer atn factory. looking at it locally but maybe you could fix it in your branch. |
No problem, let me resolve conflicts and repush it again. |
|
cool. it's looking like a very simple change! kudos. |
|
okay, everything looks good to me except for that minor capitalization thing. |
KvanTTT
force-pushed
the
caseInsensitiveLexerCommand
branch
from
71dbd36 to
a853356
Compare
* add options to lexer rules per antlr/antlr4#3437 * Fixes #525, clean up calls to antlr tool. upgrade lib versions. Seems to work with 2021.3.3 * Fixes #518 * update doc Signed-off-by: Terence Parr <parrt@antlr.org> * Allow earlier versions of intellij * add noteAbout how to remove a deprecated function in the future; I couldn't figure out how to make it work at the moment. * update doc Signed-off-by: Terence Parr <parrt@antlr.org> * remove dead code * let gradle see antlr snapshots * test with latest intellij
2 participants
It was quite simple to implement, but it should be merged after #3435