Fix some thread sanitizer warnings in C++ runtime#3309
Merged
parrt merged 2 commits intoantlr:masterfrom Oct 31, 2021
Merged
Conversation
jcking
force-pushed
the
cpp-runtime-thread-safety
branch
2 times, most recently
from
edee543 to
5bc8e01
Compare
Collaborator
Author
Member
|
Thanks for the PR. Can you also add yourself to the contributors.txt file? |
Collaborator
Author
Done. |
Collaborator
Author
Actually, I added it to #3311 instead, but same outcome. Both are TSAN fixes. |
Member
|
Please add that to this PR (too). We may not accept both patches. |
jcking
force-pushed
the
cpp-runtime-thread-safety
branch
from
5bc8e01 to
f68a89d
Compare
Collaborator
Author
Done. |
jcking
force-pushed
the
cpp-runtime-thread-safety
branch
from
f68a89d to
0d0e7b4
Compare
mike-lischke
approved these changes
Oct 31, 2021
Member
|
@parrt Another C++ only patch, ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some shared global states in the C++ runtime, specifically in the ATN, that cause thread sanitizer warnings. This pull request switches those use
std::atomic.