New JavaScript CharStreams functions

[bhamiltoncx]

Based on the discussion at #1771 (comment) , this brings the Java runtime's CharStreams factory API to JavaScript.

I updated BaseBrowserTest to illustrate usage of the new API.

[parrt]

@ericvergnaud analogous to Java, C#

[ericvergnaud]

can we use camel case for onload and onerror?

[bhamiltoncx]

Sure, will change to camel case. I was just copying the signature of FileLoader.

…

On Tue, Mar 21, 2017, 10:21 AM ericvergnaud ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In runtime/JavaScript/src/antlr4/CharStreams.js <#1776 (comment)>: > +// All returned InputStreams support the full range of Unicode +// up to U+10FFFF (the default behavior of InputStream only supports +// code points up to U+FFFF). +var CharStreams = { + // Creates an InputStream from a string. + fromString: function(str) { + return InputStream(str, true); + }, + + // Asynchronously creates an InputStream from a blob given the + // encoding of the bytes in that blob (defaults to 'utf8' if + // encoding is null). + // + // Invokes onload(result) on success, onerror(error) on + // failure. + fromBlob: function(blob, encoding, onload, onerror) { can we use camel case for onload and onerror? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1776 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApAU8yfCQyHj29zwN1GnTW0NTWc8eujks5rn_kKgaJpZM4Mi92a> .

[bhamiltoncx]

OK, changed to camelCase.

[parrt]

@bhamiltoncx are these consistent now with our tweaks to the Java stream API?

[bhamiltoncx]

Yep, all consistent (again, other than lacking a perf pass so we don't yet take a size).

[parrt]

As it looks like @ericvergnaud did not have any serious objections, I'm merging.