Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Deprecate try functions #251

Merged
merged 3 commits into from
Sep 26, 2017
Merged

[3.x] Deprecate try functions #251

merged 3 commits into from
Sep 26, 2017

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 26, 2017

Those will be removed in Result 4.0.

This is a preparation for #85.

@ikesyo ikesyo requested a review from a team September 26, 2017 13:10
@gfontenot
Copy link
Member

Do we maybe want to point people towards materialize in the message?

ashfurrow
ashfurrow approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Agreed with @gfontenot – we should point users towards a replacement method.

@ikesyo
Copy link
Member Author

ikesyo commented Sep 26, 2017

Thanks @gfontenot and @ashfurrow. Since the materialize itself is marked as deprecated on master, I pointed to Result.init(attempt:) instead.

https://github.com/antitypical/Result/blob/39e761c/Result/Result.swift#L136-L139

@gfontenot
Copy link
Member

Ah, right. 👍

@ikesyo ikesyo merged commit 1abb664 into 3.x Sep 26, 2017
@ikesyo ikesyo deleted the deprecate-try-functions branch September 26, 2017 14:35
@ikesyo ikesyo mentioned this pull request Oct 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikesyo @gfontenot @ashfurrow