(fix) deployment name in Makefile load-image directive #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haq204
approved these changes
Jul 10, 2025
jra3
added a commit
that referenced
this pull request
Oct 9, 2025
… stripping
add container-specific human-readable identifier fields (container_name, workload_name) to metadata extraction and container graph nodes, enabling intuitive container identification across all runtimes without duplicating kubernetes pod-level fields.
container_name extraction:
- prioritize kubernetes container name from io.kubernetes.container.name label
- fall back to docker compose service name (com.docker.compose.service)
- default to image name when no explicit container name available
- provides consistent naming across kubernetes, docker, containerd, cri-o, podman runtimes
workload_name extraction with hash stripping:
- derive workload names from kubernetes pod names by stripping generated hashes
- strip both replicaset hash and pod hash (e.g., "web-server-7d4f8bd9c-abc12" -> "web-server")
- detect kubernetes hashes using alphanumeric pattern matching (5-10 chars with both letters and digits)
- preserve non-deployment pod names like statefulsets ("cassandra-0" -> "cassandra-0")
- only populate for kubernetes containers (requires io.kubernetes.pod.name label)
integration:
- add fields to internal/containers/graph/builder.go ContainerInfo struct
- populate fields in graph/nodes.go createContainerNode()
- extract names in manager.go collectRuntimeSnapshot() with sample logging
- update protobuf bindings (pkg/api/antimetal/runtime/v1/linux.pb.go) from jra3-apis PR #14
design decisions:
- container-specific fields only (no duplication of pod name, namespace, app)
- pod-level fields available via kubernetes pod resources and container->pod relationships
- graceful degradation when labels unavailable (fields remain empty)
- hash detection algorithm balances precision (avoid false positives) with recall (catch k8s hashes)
testing:
- 24 test cases across 6 test functions
- comprehensive coverage of extractHumanNames() with kubernetes/docker/fallback scenarios
- thorough stripPodHash() testing with deployments, statefulsets, edge cases
- helper function tests (isAlphanumeric, isKubernetesHash)
Note: 🤖 This commit includes significant code written with Claude Code assistance
Depends-On: jra3-apis#14
8 tasks
jra3
added a commit
that referenced
this pull request
Oct 21, 2025
… stripping
add container-specific human-readable identifier fields (container_name, workload_name) to metadata extraction and container graph nodes, enabling intuitive container identification across all runtimes without duplicating kubernetes pod-level fields.
container_name extraction:
- prioritize kubernetes container name from io.kubernetes.container.name label
- fall back to docker compose service name (com.docker.compose.service)
- default to image name when no explicit container name available
- provides consistent naming across kubernetes, docker, containerd, cri-o, podman runtimes
workload_name extraction with hash stripping:
- derive workload names from kubernetes pod names by stripping generated hashes
- strip both replicaset hash and pod hash (e.g., "web-server-7d4f8bd9c-abc12" -> "web-server")
- detect kubernetes hashes using alphanumeric pattern matching (5-10 chars with both letters and digits)
- preserve non-deployment pod names like statefulsets ("cassandra-0" -> "cassandra-0")
- only populate for kubernetes containers (requires io.kubernetes.pod.name label)
integration:
- add fields to internal/containers/graph/builder.go ContainerInfo struct
- populate fields in graph/nodes.go createContainerNode()
- extract names in manager.go collectRuntimeSnapshot() with sample logging
- update protobuf bindings (pkg/api/antimetal/runtime/v1/linux.pb.go) from jra3-apis PR #14
design decisions:
- container-specific fields only (no duplication of pod name, namespace, app)
- pod-level fields available via kubernetes pod resources and container->pod relationships
- graceful degradation when labels unavailable (fields remain empty)
- hash detection algorithm balances precision (avoid false positives) with recall (catch k8s hashes)
testing:
- 24 test cases across 6 test functions
- comprehensive coverage of extractHumanNames() with kubernetes/docker/fallback scenarios
- thorough stripPodHash() testing with deployments, statefulsets, edge cases
- helper function tests (isAlphanumeric, isKubernetesHash)
Note: 🤖 This commit includes significant code written with Claude Code assistance
Depends-On: jra3-apis#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just agent now