Skip to content

fix: add baseUrl to Octokit initialization in update_claude_comment #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashwin-ant merged 4 commits into from
Jun 11, 2025
Merged

fix: add baseUrl to Octokit initialization in update_claude_comment #157

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fae65b
fix: add baseUrl to Octokit initialization in update_claude_comment
claude[bot] Jun 11, 2025
4f6cefd
fix: pass GITHUB_API_URL as env var to MCP server
claude[bot] Jun 11, 2025
22e1d39
fix: import GITHUB_API_URL from config in install-mcp-server
claude[bot] Jun 11, 2025
3373efd
fix
ashwin-ant Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mcp/github-file-ops-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { z } from "zod";
import { readFile } from "fs/promises";
import { join } from "path";
import fetch from "node-fetch";
import { GITHUB_API_URL } from "../github/api/config";
import { Octokit } from "@octokit/rest";
import { updateClaudeComment } from "../github/operations/comments/update-claude-comment";

Expand Down Expand Up @@ -40,6 +39,7 @@ const REPO_OWNER = process.env.REPO_OWNER;
const REPO_NAME = process.env.REPO_NAME;
const BRANCH_NAME = process.env.BRANCH_NAME;
const REPO_DIR = process.env.REPO_DIR || process.cwd();
const GITHUB_API_URL = process.env.GITHUB_API_URL || "https://api.github.com";

if (!REPO_OWNER || !REPO_NAME || !BRANCH_NAME) {
console.error(
Expand Down Expand Up @@ -466,6 +466,7 @@ server.tool(

const octokit = new Octokit({
auth: githubToken,
baseUrl: GITHUB_API_URL,
});

const isPullRequestReviewComment =
Expand Down
1 change: 1 addition & 0 deletions src/mcp/install-mcp-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export async function prepareMcpConfig(
...(claudeCommentId && { CLAUDE_COMMENT_ID: claudeCommentId }),
GITHUB_EVENT_NAME: process.env.GITHUB_EVENT_NAME || "",
IS_PR: process.env.IS_PR || "false",
GITHUB_API_URL: process.env.GITHUB_API_URL || "https://api.github.com",

@ashwin-ant ashwin-ant Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude let's get the api url from src/github/api/config.ts when passing it here

@claude claude Bot Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude finished @ashwin-ant's task in 2m 28s —— View job

Todo List:

  • Read src/mcp/install-mcp-server.ts to understand current implementation
  • Read src/github/api/config.ts to see how GITHUB_API_URL is exported
  • Import GITHUB_API_URL from config and use it when passing to MCP server
  • Run tests to ensure the change doesn't break anything
  • Commit and push the change

Summary

Updated src/mcp/install-mcp-server.ts to import and use GITHUB_API_URL from src/github/api/config.ts instead of reading process.env.GITHUB_API_URL directly. This ensures consistency with how the API URL is handled throughout the codebase.

All tests are passing (201 tests, 0 failures).

},
},
},
Expand Down