Skip to content

fix(examples): correct message ordering in memory tool example #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(examples): correct message ordering in memory tool example #1052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions examples/memory/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ def conversation_loop():
raise

# Process all messages from the runner
assistant_content: list[BetaContentBlockParam] = []
for message in runner:
spinner.stop()

Expand All @@ -350,7 +349,8 @@ def conversation_loop():
for edit in message.context_management.applied_edits:
print(f"\n🧹 [Context Management: {edit.type} applied]")

# Process content blocks
# Process content blocks - create assistant_content for THIS iteration
assistant_content: list[BetaContentBlockParam] = []
for content in message.content:
if content.type == "text":
print(content.text, end="", flush=True)
Expand All @@ -371,7 +371,11 @@ def conversation_loop():
}
)

# Generate tool response automatically
# Append assistant message FIRST (before tool result)
if assistant_content:
messages.append({"role": "assistant", "content": assistant_content})

# THEN generate and append tool response
tool_response = runner.generate_tool_call_response()
if tool_response and tool_response["content"]:
# Add tool results to messages
Expand All @@ -381,10 +385,6 @@ def conversation_loop():
if isinstance(result, dict) and result.get("type") == "tool_result":
print(f"[Tool result processed]")

# Store assistant message
if assistant_content:
messages.append({"role": "assistant", "content": assistant_content})

print()


Expand Down