Support count tokens for bedrock client #1043
Open
+69
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support count tokens API for bedrock client.
count-tokensis now supported by Amazon Bedrock (link). Anthropic python SDK doesn't support it, maybe because it was supported very recently.Supporting it can simplify our codebase. We can switch model provider without rewriting code for bedrock.
Tested it with the example locally. Compared the number of tokens with the result of bedrock client, and they had the same number if the input was the same.
Questions:
max_tokensin the request and it was not passed by Anthropic's count_tokens method. Is it OK to pass the fixed number (now 500)?