[Fix] Add missing error mappings to Vertex AI client #1015
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing HTTP status code mappings in the Vertex AI client's
_make_status_errormethod to ensure consistent error handling with the main Anthropic client.Changes
RequestTooLargeErrorOverloadedErrorBackground
The Vertex AI client was missing mappings for these error types that are already defined in
_exceptions.pyand used by other clients in the SDK. This ensures that users get the appropriate exception types rather than genericAPIStatusErrororInternalServerErrorinstances when these status codes are returned.These error types are already defined in the main exceptions module and used consistently across other parts of the SDK.