Improve reporting of token counts in UsageDetails #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephentoub
commented
Dec 10, 2025
stephentoub
commented
- InputTokenCount needs to reflect cached tokens.
- Only add to AdditionalCounts for positive counts.
- Added reporting of WebFetch/SearchRequests.
sd-st
approved these changes
Dec 10, 2025
Collaborator
|
@stephentoub failing lint FYI |
stephentoub
force-pushed
the
fixtokens
branch
from
30550d1 to
d6d548c
Compare
Collaborator
|
@stephentoub still failing unfortunately |
- InputTokenCount needs to reflect cached tokens. - Only add to AdditionalCounts for positive counts. - Added reporting of WebFetch/SearchRequests.
stephentoub
force-pushed
the
fixtokens
branch
from
d6d548c to
5a26c78
Compare
Contributor
Author
|
grrrrrrrrrrrrr.... updated |
stainless-app bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
* Improve reporting of token counts in UsageDetails - InputTokenCount needs to reflect cached tokens. - Only add to AdditionalCounts for positive counts. - Added reporting of WebFetch/SearchRequests. * lint * lint take 2
felixfbecker
pushed a commit
that referenced
this pull request
Dec 18, 2025
* Improve reporting of token counts in UsageDetails - InputTokenCount needs to reflect cached tokens. - Only add to AdditionalCounts for positive counts. - Added reporting of WebFetch/SearchRequests. * lint * lint take 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.