fix(client): return correct type for foundry#WithOptions #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packyg
previously approved these changes
Nov 19, 2025
src/Anthropic/AnthropicClient.cs
Outdated
Comment on lines
17
to
30
| public AnthropicClient() | ||
| { | ||
| _options = new(); | ||
|
|
||
| _messages = new(() => new MessageService(this)); | ||
| _models = new(() => new ModelService(this)); | ||
| _beta = new(() => new BetaService(this)); | ||
| } | ||
|
|
||
| public AnthropicClient(ClientOptions options) | ||
| : this() | ||
| { | ||
| _options = options; | ||
| } |
Collaborator
There was a problem hiding this comment.
Let's not move this. It's going to cause merge conflicts with codegen whenever we change the constructors in codegen
Collaborator
There was a problem hiding this comment.
If you think we should be moving the constructors elsewhere in the ordering for style reasons then let me know and I'll move them in codegen
Contributor
Author
There was a problem hiding this comment.
yes constructors generally come after private and static members but before all other methods and properties. See AnthropicFoundryClient.cs:22
Collaborator
There was a problem hiding this comment.
Cool, I'll file a ticket to do that, thanks :)
TomerAberbach
approved these changes
Nov 19, 2025
TomerAberbach
changed the title
Merged
stainless-app bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Make WithOptions virtual and return correct type on foundry implementation * code cleanup * revert moving constructor * fix indentation
JPVenson
added a commit
to JPVenson/anthropic-sdk-csharp
that referenced
this pull request
Nov 20, 2025
* Make WithOptions virtual and return correct type on foundry implementation * code cleanup * revert moving constructor * fix indentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17