Skip to content

chore(react): move no-implicit-key as typeAwareRule#808

Closed
johannpinson wants to merge 1 commit intoantfu:mainfrom
johannpinson:chore/eslint-react-upgrade
Closed

chore(react): move no-implicit-key as typeAwareRule#808
johannpinson wants to merge 1 commit intoantfu:mainfrom
johannpinson:chore/eslint-react-upgrade

Conversation

@johannpinson
Copy link
Contributor

  • <- Keep this line and put an x between the brackts.

Description

With the release of the v2.10.0 of @eslint-react/eslint-plugin the rule react/no-implicit-key is now a "strict-type-checked" rule (cf. https://github.com/Rel1cx/eslint-react/releases/tag/v2.10.0 or https://www.eslint-react.xyz/docs/rules/no-implicit-key).

I move the rule inside the typeAwareRules vars in the react config file.

Without this change this kind of error will appear:

Error: Error while loading rule 'react/no-implicit-key': You have used a rule which requires type information, but don't have parserOptions set to generate type information for this file. See https://tseslint.com/typed-linting for enabling linting with type information.
Parser: (unknown)
Note: detected a parser other than @typescript-eslint/parser. Make sure the parser is configured to forward "parserOptions.project" to @typescript-eslint/parser.
Occurred while linting /Users/xxx/xxx/xxx/eslint.config.mjs

Additional context

Since I don't use pnpm, I don't update any pnpm file (workspace or lock file).
I'm also no familiar with the testing process, but I still update the full-on.snap.js.

Moreover, the latest release is the v2.11.0` that I chnage on the devDeps in pkg.json, but this minimal version requirement should be updated more globally, but this PR seems at least revelant to start a fix about this change whit the react plugin.

I will stay available if I can help anything about this point.

@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for melodious-froyo-4871f8 ready!

Name Link
🔨 Latest commit 9e876fd
🔍 Latest deploy log https://app.netlify.com/projects/melodious-froyo-4871f8/deploys/6985fcc10ad0a00008d9f67c
😎 Deploy Preview https://deploy-preview-808--melodious-froyo-4871f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@antfu
Copy link
Owner

antfu commented Feb 7, 2026

Thank you but it seems #810 has already covered it.

@antfu antfu closed this Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants