chore(react): move no-implicit-key as typeAwareRule#808
Closed
johannpinson wants to merge 1 commit intoantfu:mainfrom
Closed
chore(react): move no-implicit-key as typeAwareRule#808johannpinson wants to merge 1 commit intoantfu:mainfrom
johannpinson wants to merge 1 commit intoantfu:mainfrom
Conversation
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
Thank you but it seems #810 has already covered it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xbetween the brackts.Description
With the release of the v2.10.0 of
@eslint-react/eslint-pluginthe rulereact/no-implicit-keyis now a "strict-type-checked" rule (cf. https://github.com/Rel1cx/eslint-react/releases/tag/v2.10.0 or https://www.eslint-react.xyz/docs/rules/no-implicit-key).I move the rule inside the
typeAwareRulesvars in the react config file.Without this change this kind of error will appear:
Additional context
Since I don't use pnpm, I don't update any pnpm file (workspace or lock file).
I'm also no familiar with the testing process, but I still update the
full-on.snap.js.Moreover, the latest release is the v2.11.0` that I chnage on the devDeps in pkg.json, but this minimal version requirement should be updated more globally, but this PR seems at least revelant to start a fix about this change whit the react plugin.
I will stay available if I can help anything about this point.