Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: manage relative URL #25

Closed
creekorful opened this issue Jan 21, 2021 · 1 comment · Fixed by #29
Closed

bug: manage relative URL #25

creekorful opened this issue Jan 21, 2021 · 1 comment · Fixed by #29
Assignees
Labels

Comments

@creekorful
Copy link
Collaborator

creekorful commented Jan 21, 2021

I've noticed a little bug while browsing my own RSS sources: https://blog.creekorful.com/index.xml

As you can see, the link are relative and therefore terminews is unable to open them. I think we should append the host to the link if the link is relative.

I'm be willing to do the PR, of course.

The problem is relative to this specific part of code:

CurrentContent, _ = GetContent(event.Url)

I've take a lot at the source code, and I have some suggestions to refactor the code a bit if you consider it! Getting rid of the global variables and make the function more state-less to ease maintenance. Would your consider it?

@antavelos
Copy link
Owner

@creekorful Good catch! ;) Feel free to do the PR!

The app indeed needs some serious refactoring. I developed it while learning Go and the code obviously lacks cohesion. Last year I started re-writing big part of the app but never completed it...

I really appreciate your willingness to contribute and revive this app. My time this period is kinda limited but I'd be glad to review any relevant PR :)

@creekorful creekorful added the bug label Jan 24, 2021
@creekorful creekorful self-assigned this Mar 4, 2021
creekorful added a commit that referenced this issue Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants