Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s3PathStyleAccessEnabled setting #6671

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Conversation

burak-58
Copy link
Contributor

PathStyleAccessEnabled configuration parameter is added to application settings.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement.
One thing need to removed and make the test coverage pass the %80

src/main/java/io/antmedia/AppSettings.java Outdated Show resolved Hide resolved
@mekya mekya changed the title add s3PathStyleAccessEnabled setting Add s3PathStyleAccessEnabled setting Jan 29, 2025
@mekya mekya merged commit bfd767e into master Jan 29, 2025
9 checks passed
@mekya mekya deleted the s3PathStyleAccessConfiguration branch January 29, 2025 15:03
@mekya mekya self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants