-
-
Notifications
You must be signed in to change notification settings - Fork 834
fix: watch config three sub-items #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthrough本次更改针对 Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses a bug fix by modifying the dependency array in a React hook to listen to three specific sub-items ( Changes
🪧 TipsFor further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me. |
@@ -113,6 +113,6 @@ export default function useXAgent< | |||
...restConfig, | |||
}), | |||
] as const, | |||
[config], | |||
[config?.baseURL, config?.dangerouslyApiKey, config?.model], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from [config]
to [config?.baseURL, config?.dangerouslyApiKey, config?.model]
ensures that the hook only re-runs when these specific sub-items change, which is a more efficient and targeted approach. However, ensure that these properties are always available or handle cases where they might be undefined
to prevent potential runtime errors.
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 66 66
Lines 1494 1494
Branches 389 406 +17
=======================================
Hits 1380 1380
Misses 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix(attachment): fix image display style (#751) * chore: update CodePreviewer to support React 19 (#758) * docs: update a new contributions charts (#761) * fix: fix some potential issue (#773) * refactor: using setState function (#774) Co-authored-by: vanndxh <[email protected]> * type: fix some potential issue (#775) * fix: watch config three sub-items (#777) * feat: function setState * fix: watch config --------- Co-authored-by: vanndxh <[email protected]> * fix: fix Conversations ellipsis tooltip issues by removing it (#776) * fix: fix Conversations ellipsis tooltip issues by removing it * test: update snapshot * style: use native text overflow style * docs: changelog of 1.2.0 (#778) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * 🏷️ type: add Conversation type export (#258) Co-authored-by: afc163 <[email protected]> * docs: fix the wrong docs of ThoughtChain (#781) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: fix the wrong docs of ThoughtChain * docs: optimize Bubble.List scoll position * docs: fix thought-chain and changelog * fix: Prompts scroll styles (#785) * fix: Prompts srollX * fix: Prompts srollX * docs: optimize Bubble.List scroll bar position (#783) * docs: optimize Bubble.List scoll position * docs: optimize Bubble.List scoll position * test: demo snap * fix: Prompts srollX * chore: sync main to feature branch --------- Co-authored-by: wzc520pyfm <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: Shinji-Li <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vanndxh <[email protected]> Co-authored-by: vanndxh <[email protected]> Co-authored-by: afc163 <[email protected]>
* chore: sync main to feature branch (#810) * fix(attachment): fix image display style (#751) * chore: update CodePreviewer to support React 19 (#758) * docs: update a new contributions charts (#761) * fix: fix some potential issue (#773) * refactor: using setState function (#774) Co-authored-by: vanndxh <[email protected]> * type: fix some potential issue (#775) * fix: watch config three sub-items (#777) * feat: function setState * fix: watch config --------- Co-authored-by: vanndxh <[email protected]> * fix: fix Conversations ellipsis tooltip issues by removing it (#776) * fix: fix Conversations ellipsis tooltip issues by removing it * test: update snapshot * style: use native text overflow style * docs: changelog of 1.2.0 (#778) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * 🏷️ type: add Conversation type export (#258) Co-authored-by: afc163 <[email protected]> * docs: fix the wrong docs of ThoughtChain (#781) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: fix the wrong docs of ThoughtChain * docs: optimize Bubble.List scoll position * docs: fix thought-chain and changelog * fix: Prompts scroll styles (#785) * fix: Prompts srollX * fix: Prompts srollX * docs: optimize Bubble.List scroll bar position (#783) * docs: optimize Bubble.List scoll position * docs: optimize Bubble.List scoll position * test: demo snap * fix: Prompts srollX * chore: sync main to feature branch --------- Co-authored-by: wzc520pyfm <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: Shinji-Li <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vanndxh <[email protected]> Co-authored-by: vanndxh <[email protected]> Co-authored-by: afc163 <[email protected]> * chore: fix warning of deprecated API (#827) * chore: fix warning of deprecated API * chore: fix ts * chore: fix logic * test: ignore legacy * chore: delete webpack.config.js (#229) * docs(bubble): update content and messageRender type (#814) * docs: sender supplement documents to address user inquiries (#835) * docs: supplement documents to address user inquiries * docs: sender * chore: sync main to feature branch * feat: make the Bubble foot and header to get from context & Bubble can get key (#683) * feat: 调整Bubble foot,header参数,支持头部获取上下文 * fix: # 支持useXAgent通过deps 获取最新状态 * fix: 剔多余提交 * fix: 英文文档格式修复 * fix 简化参数 * Update header-and-footer.tsx fix: 调整用例 * feat: bubble's footer and header * feat: bubble's footer and header * test: bubble's footer and header * fix: ts of key * fix: ts of key --------- Co-authored-by: Mickey <[email protected]> * fix: resolve the security issues of apikey (#840) * fix: Resolve the security issues of apikey * fix: Resolve the security issues of apikey * test: update snap * fix:api key and stream * fix:api key and stream * docs: modification tips (#844) * docs: changelog of 1.3.0 (#845) * test: sender * test: delete * docs: changelog of 1.3.0 * docs: changelog of 1.3.0 * docs: changelog of 1.3.0 --------- Co-authored-by: wzc520pyfm <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: Shinji-Li <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vanndxh <[email protected]> Co-authored-by: vanndxh <[email protected]> Co-authored-by: afc163 <[email protected]> Co-authored-by: 二货爱吃白萝卜 <[email protected]> Co-authored-by: Lawliet <[email protected]>
* feat: function setState * fix: watch config --------- Co-authored-by: vanndxh <[email protected]>
* fix(attachment): fix image display style (ant-design#751) * chore: update CodePreviewer to support React 19 (ant-design#758) * docs: update a new contributions charts (ant-design#761) * fix: fix some potential issue (ant-design#773) * refactor: using setState function (ant-design#774) Co-authored-by: vanndxh <[email protected]> * type: fix some potential issue (ant-design#775) * fix: watch config three sub-items (ant-design#777) * feat: function setState * fix: watch config --------- Co-authored-by: vanndxh <[email protected]> * fix: fix Conversations ellipsis tooltip issues by removing it (ant-design#776) * fix: fix Conversations ellipsis tooltip issues by removing it * test: update snapshot * style: use native text overflow style * docs: changelog of 1.2.0 (ant-design#778) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * 🏷️ type: add Conversation type export (ant-design#258) Co-authored-by: afc163 <[email protected]> * docs: fix the wrong docs of ThoughtChain (ant-design#781) * fix: fix some potential issue * fix: fix some potential issue * fix: fix some potential issue * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: changelog of 1.2.0 * docs: fix the wrong docs of ThoughtChain * docs: optimize Bubble.List scoll position * docs: fix thought-chain and changelog * fix: Prompts scroll styles (ant-design#785) * fix: Prompts srollX * fix: Prompts srollX * docs: optimize Bubble.List scroll bar position (ant-design#783) * docs: optimize Bubble.List scoll position * docs: optimize Bubble.List scoll position * test: demo snap * fix: Prompts srollX * chore: sync main to feature branch --------- Co-authored-by: wzc520pyfm <[email protected]> Co-authored-by: ice <[email protected]> Co-authored-by: Shinji-Li <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vanndxh <[email protected]> Co-authored-by: vanndxh <[email protected]> Co-authored-by: afc163 <[email protected]>
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
📝 Change Log
Summary by CodeRabbit