fix: root selector with single & #193
Conversation
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
🎊 PR Preview 4f52951 has been successfully built and deployed to https://ant-design-cssinjs-preview-pr-193.surge.sh 🕐 Build time: 96.645s
🤖 By surge-preview |
WalkthroughThe changes consist of an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
@SocketSecurity ignore npm/[email protected] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 94.36% 95.07% +0.71%
==========================================
Files 29 33 +4
Lines 2661 2883 +222
Branches 398 456 +58
==========================================
+ Hits 2511 2741 +230
+ Misses 150 142 -8 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- package.json (1 hunks)
- src/hooks/useStyleRegister.tsx (1 hunks)
- tests/index.spec.tsx (1 hunks)
Additional comments not posted (3)
package.json (1)
49-49: Verify compatibility with the updatedstylisversion.The
stylispackage version has been updated from^4.0.13to^4.3.3. Ensure that this update is compatible with the rest of the codebase and does not introduce any breaking changes.Run the following script to check for any breaking changes or compatibility issues:
src/hooks/useStyleRegister.tsx (1)
239-241: Verify the impact of handling the root selector with a single&.The
parseStylefunction has been modified to handle the root selector with a single&differently. Ensure that this change does not introduce any unintended side effects and that it behaves as expected in all scenarios.Run the following script to verify the impact of this change:
tests/index.spec.tsx (1)
781-813: LGTM! The new test case is well-structured and comprehensive.The 'hash & nest style' test case effectively verifies the correct generation and application of CSS styles using a hash mechanism. It enhances the test coverage for the CSS styling functionality.
Summary by CodeRabbit
New Features
stylispackage to improve performance and potentially introduce new features.Tests