Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: support ssr for improve seo #1257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: support ssr for improve seo #1257

wants to merge 2 commits into from
+6,022 −2,043

Conversation

yutingzhao1991
Copy link
Collaborator

@yutingzhao1991 yutingzhao1991 commented Nov 20, 2024 •
edited
Loading

添加 dumi ssr 配置，提升首页渲染速度和 SEO close #1212

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ❌ Failed (Inspect) Nov 20, 2024 9:12am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: e2c87bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Preview Failed

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@umijs/[email protected]

View full report↗︎

thinkasany
thinkasany reviewed Nov 20, 2024
View reviewed changes
.dumi/pages/index/components/ShowCase/index.tsx
Comment on lines +24 to +29
const caseList = [
<Connect key="connect" />,
<NFTCard key="nftcard" />,
<PayPanel key="paypanel" />,
<CryptoInput key="cryptoinput" />,
];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const caseList = [
<Connect key="connect" />,
<NFTCard key="nftcard" />,
<PayPanel key="paypanel" />,
<CryptoInput key="cryptoinput" />,
];
const caseList = [
<Connect key="Connect" />,
<NFTCard key="NFTCard" />,
<PayPanel key="PayPanel" />,
<CryptoInput key="CryptoInput" />,
];

.dumirc.ts
@@ -52,6 +52,12 @@ export default defineConfig({
gtag('config', 'G-C31HWEY1D4');
`,
],
ssr: {
// for improve seo
// 需要使用 React 18.3.0-canary-c3048aab4-20240326 版本，因为 umi 是基于整个 HTML 做的水合，在 18.3.1 版本有 bug，会导致浏览器插件的内容影响水合
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可是antd侧的react版本也是18.3.1，是 web3 相关的插件有啥影响吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkasany thinkasany thinkasany left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] improve SEO for Ant Design Web3 website
2 participants
@yutingzhao1991 @thinkasany