Config code split #562
Merged
Config code split #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个插件简直完美。。我去膜拜一下 |
| const dynamicWrapper = (app, models, component) => { | ||
| // () => require('module') | ||
| // transformed by babel-plugin-dynamic-import-node-sync | ||
| if (component.toString().indexOf('.then(') < 0) { |
There was a problem hiding this comment.
区别是 () => import('module') 还是转换过的 () => require('module')。目前没有找到更好的方案。
There was a problem hiding this comment.
希望webpack未来出一个api，实现的感觉还是打补丁的感觉
|
afc163
referenced
this pull request
in ant-design/ant-design-pro-site
Jan 5, 2018
|
你为什么能通过ci检查? |
afc163
force-pushed
the
config-code-split
branch
from
40e95db
to
bb2b78c
Compare
afc163
force-pushed
the
config-code-split
branch
from
bb2b78c
to
717513b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/seeden/babel-plugin-dynamic-import-node-sync
Defaultly, app would be bundled as one file.
The code split will works if you remove
dynamic-import-node-syncin.roadhogrc.close #470
close #524