feat(deps): add react-dom peer deps #6611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 https://bundlephobia.com/package/antd-mobile 上,bundle 分析会提示 react-dom 没有找到
理论上任何会被 bundle 的依赖都应该在 dependencies 或者 peerDependencies 里。参考 antd 的 peerDependencies 就是有 react-dom 的,所以我在 antd-mobile 里也加上了。这样更加严谨一些,也能让 bundlephobia.com 之类的工具分析得更准确一些。