Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(infinite-scroll): optimize error handling in scroll functions #6531

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

chooin
Copy link
Contributor

@chooin chooin commented Jan 23, 2024

No description provided.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7a14295) 92.27% compared to head (644638a) 92.23%.
Report is 1 commits behind head on master.

❗ Current head 644638a differs from pull request most recent head fa263d8. Consider uploading reports for the commit fa263d8 to get more accurate results

Files Patch % Lines
src/components/infinite-scroll/infinite-scroll.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6531      +/-   ##
==========================================
- Coverage   92.27%   92.23%   -0.04%     
==========================================
  Files         316      316              
  Lines        6897     6901       +4     
  Branches     1728     1728              
==========================================
+ Hits         6364     6365       +1     
- Misses        497      500       +3     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6531.surge.sh

Copy link
Member

@zombieJ zombieJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it can be use try catch to simplify logic.

@zombieJ zombieJ merged commit 5346557 into ant-design:master Feb 5, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Deploy PR preview failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants