Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VirtualInput): should not block of long press #6477

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(VirtualInput): should not block of long press #6477

merged 2 commits into from
Dec 13, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 13, 2023

长按后聚焦元素不在 root 上,关闭逻辑里加一个聚焦让它可以正确触发。

close #6474

PS: 测试中调用 blur 事件即便 activeElement 不在元素上也能触发,看起来测试中没有办法去模拟真实的场景。

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dcff0b8) 92.28% compared to head (eb11ebf) 92.24%.

Files Patch % Lines
src/components/number-keyboard/number-keyboard.tsx 0.00% 2 Missing ⚠️
src/components/virtual-input/virtual-input.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6477      +/-   ##
==========================================
- Coverage   92.28%   92.24%   -0.04%     
==========================================
  Files         316      316              
  Lines        6866     6872       +6     
  Branches     1720     1722       +2     
==========================================
+ Hits         6336     6339       +3     
- Misses        494      497       +3     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6477.surge.sh

Copy link

@wangshihao111 wangshihao111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Size Change: +90 B (0%)

Total Size: 367 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 195 kB +48 B (0%)
./lib/bundle/antd-mobile.umd.js 153 kB +42 B (0%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.42 kB
./lib/bundle/style.css 18 kB

compressed-size-action

@zombieJ zombieJ merged commit 1756288 into master Dec 13, 2023
9 checks passed
@zombieJ zombieJ deleted the fix-press branch December 13, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants