-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swiper): support RTL mode #6450
base: master
Are you sure you want to change the base?
Conversation
src/components/swiper/index.en.md
Outdated
@@ -36,6 +36,10 @@ When you use a vertical Swiper, be sure to set its height through the `--height` | |||
|
|||
<code src="./demos/demo7.tsx" debug></code> | |||
|
|||
### rtl support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
写个demo 就够了,不必再起一行说明吧~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我把这里精简一下
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6450.surge.sh |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6450 +/- ##
==========================================
+ Coverage 92.10% 92.25% +0.15%
==========================================
Files 316 316
Lines 6861 6883 +22
Branches 1719 1743 +24
==========================================
+ Hits 6319 6350 +31
+ Misses 504 497 -7
+ Partials 38 36 -2 ☔ View full report in Codecov by Sentry. |
@1587315093 修改过了,麻烦再review一下哇 |
@zombieJ 麻烦看一下呢,这个提交已经pending一个月了 |
大佬们,什么时候合并一下这个需求,正好有阿拉伯语地区的适配需求,目前只能写死覆盖好几处direction: rtl; |
@zombieJ +1 |
@asd116725 @cbbfcd 这个 PR 代码冲突了,需要 @RaHsu 解决一下先。 |
ref: #6446
Swiper components support RTL