Conversation
github-actions
bot
added
documentation
RobPasMue
commented
Jun 4, 2025
jorgepiloto
reviewed
Jun 4, 2025
jorgepiloto
reviewed
Jun 4, 2025
jorgepiloto
reviewed
Jun 4, 2025
jorgepiloto
reviewed
Jun 4, 2025
jorgepiloto
reviewed
Jun 4, 2025
jorgepiloto
previously requested changes
Jun 4, 2025
Member
jorgepiloto
left a comment
jorgepiloto
left a comment
There was a problem hiding this comment.
Thanks for adding this, @RobPasMue. Just left some minor suggestions.
klmcadams
reviewed
Jun 4, 2025
Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com>
SMoraisAnsys
reviewed
Jun 4, 2025
Contributor
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Thanks for this guide line @RobPasMue, I left minor comments
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
RobPasMue
commented
Jun 5, 2025
SMoraisAnsys
reviewed
Jun 5, 2025
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
clatapie
approved these changes
Jun 6, 2025
Contributor
clatapie
left a comment
clatapie
left a comment
There was a problem hiding this comment.
LGTM, the content is clear for the PyAnsys developers and for the PyAnsys Core team.
RobPasMue
dismissed
jorgepiloto’s stale review
Points blocking have been left as they were after internal discussion
github-actions bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
* docs: deprecating a library * docs: missing explanation * fix: vale issues * fix: pre-commit * Update doc/source/how-to/deprecating.rst * fix: removing ref * fix: remove line * Apply suggestions from code review Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> * Apply suggestions from code review * Update doc/source/how-to/deprecating.rst Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> * docs: adding documentation banner --------- Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com> Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title says - this documentation shows how to properly deprecate a library and the tasks involved on the @ansys/pyansys-core team side