Skip to content

fix: use persistent container for execution environment commands #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lalten wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: use persistent container for execution environment commands #2721

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4dc37fe
use persistent container for execution environment commands
lalten Apr 7, 2026
a124445
copilot review
lalten Apr 7, 2026
9364391
rm unused `uuid`
lalten Apr 7, 2026
33f3917
rm `container exec invocation` log spam
lalten Apr 7, 2026
0761ce4
annotate untestable coverage lines
lalten Apr 7, 2026
e2024e7
review
lalten Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/ansible-language-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"handlebars": "^4.7.8",
"ini": "^6.0.0",
"lodash": "^4.17.23",
"uuid": "^13.0.0",
"vscode-languageserver": "^9.0.1",
"vscode-languageserver-protocol": "^3.17.5",
"vscode-languageserver-textdocument": "^1.0.12",
Expand Down
11 changes: 11 additions & 0 deletions packages/ansible-language-server/src/ansibleLanguageService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export class AnsibleLanguageService {
public initialize(): void {
this.initializeConnection();
this.registerLifecycleEventHandlers();
this.registerShutdownHandler();
}

private initializeConnection() {
Expand Down Expand Up @@ -364,6 +365,16 @@ export class AnsibleLanguageService {
);
}

private registerShutdownHandler() {
/* v8 ignore next 6 */
this.connection.onShutdown(async () => {
// Dispose all persistent EE containers on language server shutdown
await this.workspaceManager.forEachContext(async (context) => {
await context.disposeExecutionEnvironment();
});
});
}

private handleError(error: unknown, contextName: string) {
const leadMessage = `An error occurred in '${contextName}' handler: `;
if (error instanceof Error) {
Expand Down
Loading
Loading