Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor work units and added tests for command.go #899

Merged
merged 21 commits into from
Jan 15, 2024
Merged

Refactor work units and added tests for command.go #899

merged 21 commits into from
Jan 15, 2024

Conversation

resoluteCoder
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 162 lines in your changes are missing coverage. Please review.

Comparison is base (1e275cb) 33.45% compared to head (7236810) 35.63%.

@@            Coverage Diff             @@
##            devel     #899      +/-   ##
==========================================
+ Coverage   33.45%   35.63%   +2.17%     
==========================================
  Files          40       40              
  Lines        7409     7439      +30     
==========================================
+ Hits         2479     2651     +172     
+ Misses       4788     4641     -147     
- Partials      142      147       +5
Files Coverage Δ
pkg/workceptor/controlsvc.go 0.00% <0.00%> (ø)
pkg/workceptor/workceptor.go 18.07% <33.33%> (+1.14%) ⬆️
pkg/workceptor/python.go 7.89% <0.00%> (ø)
pkg/workceptor/workunitbase.go 69.81% <62.50%> (-0.38%) ⬇️
pkg/workceptor/command.go 50.31% <69.23%> (+39.06%) ⬆️
pkg/workceptor/remote_work.go 4.48% <20.58%> (+4.48%) ⬆️
pkg/workceptor/kubernetes.go 2.96% <3.37%> (-0.01%) ⬇️

... and 4 files with indirect coverage changes

@resoluteCoder resoluteCoder marked this pull request as ready for review December 11, 2023 16:27
@resoluteCoder resoluteCoder force-pushed the refactor-work-units-gasp branch 6 times, most recently from c71fefd to 7553e1c Compare December 11, 2023 18:30
AaronH88
AaronH88 reviewed Dec 12, 2023
View reviewed changes
pkg/workceptor/command.go Outdated Show resolved Hide resolved
@resoluteCoder resoluteCoder force-pushed the refactor-work-units-gasp branch 8 times, most recently from c65d08c to 9cb8e3a Compare December 15, 2023 20:10
@resoluteCoder resoluteCoder force-pushed the refactor-work-units-gasp branch 2 times, most recently from b232e9e to 7676c03 Compare January 11, 2024 22:39
@resoluteCoder resoluteCoder changed the title Refactor work units gasp Refactor work units and added tests for command.go Jan 12, 2024
@resoluteCoder resoluteCoder force-pushed the refactor-work-units-gasp branch 3 times, most recently from a31a72d to c10b8cb Compare January 12, 2024 19:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

AaronH88
AaronH88 approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AaronH88 AaronH88 merged commit 2bae5f3 into ansible:devel Jan 15, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronH88 AaronH88 AaronH88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@resoluteCoder @AaronH88