Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure modules are idempotent #320

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

alinabuzachis
Copy link
Collaborator

Ensure modules are idempotent

Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need a changelog for this? Rest LGTM

@Alex-Izquierdo
Copy link
Contributor

Do you think we need a changelog for this? Rest LGTM

@Akasurde how the change log works? I thought it would be generated automatically at the release time. If we need to do something on purpose I think #322 should have also to update the change log.

@Akasurde
Copy link
Member

@Alex-Izquierdo
See this fragment as an example for comment. These fragments will create changelog at the time of release.

@alinabuzachis
Copy link
Collaborator Author

alinabuzachis commented Sep 13, 2024

@Alex-Izquierdo See this fragment as an example for comment. These fragments will create changelog at the time of release.

The problem is that I do not see anymore the changelogs folder @Akasurde .

@Akasurde
Copy link
Member

@Alex-Izquierdo See this fragment as an example for comment. These fragments will create changelog at the time of release.

The problem is that I do not see anymore the changelogs folder @Akasurde .

Seems like GitHub release is managing the changelog. NVM, drop this review request comment.

@Akasurde Akasurde self-requested a review September 13, 2024 18:37
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis merged commit ca69f00 into ansible:main Oct 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants