Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore common linting rules #242

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Ignore common linting rules #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .config/dictionary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,13 @@ testenv
toxinidir
trustore
truststore
ARGSPEC
Nikhil
jainnikhil
Abhijeet
Kasurde
akasurde
auths
Passw
AUTHS
EDAHTTP
13 changes: 12 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,28 @@ repos:
rev: "v0.5.6"
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
args: [
--fix,
--exit-non-zero-on-fix,
--ignore, E402,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That not the right place to add ignores. You should use inline noqa for this one, or if we want to ignore it for the entire project, it would be inside pyproject.toml ruff config.

]
- repo: https://github.com/PyCQA/flake8
rev: 7.1.1
hooks:
- id: flake8
args: [
--max-line-length, "120",
--extend-ignore, E203 E402,
]

- repo: https://github.com/pycqa/pylint
rev: v3.2.6
hooks:
- id: pylint
args:
- --output-format=colorized
- --disable=C0103,C0114,C0115,C0116,R0913,R1735,
- --max-line-length=120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, not here! Otherwise running pylint outside pre-commit will show same errors (aka... vscode will stil complain!)

additional_dependencies:
- aiobotocore
- aiohttp
Expand Down