-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support headers #208
Support headers #208
Conversation
Signed-off-by: clyang82 <[email protected]> Test Signed-off-by: clyang82 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: clyang82 <[email protected]>
I am afraid sending the headers always may break the backward compatibility if someone is dealing with the whole event, including |
I think there is no risk at all, because we are extending the existing schema of the event with a new root key of the event, preserving the existing "body" key. To me we should send the headers always. |
Signed-off-by: clyang82 <[email protected]>
Thanks for your comments. Remove the option to send the headers always. |
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
fixed: #207