Merge pull request #204 from msmagnanijr/AAP-23958

[AAP-23958] -  Investigate errors in unit tests in eda collection

extensions/eda/plugins/event_source/alertmanager.py

@@ -6,7 +6,7 @@
 Arguments:
 ---------
     host: The webserver hostname to listen to. Set to 0.0.0.0 to listen on all
-          interfaces. Defaults to 127.0.0.1
+          interfaces. Defaults to localhost
     port: The TCP port to listen to.  Defaults to 5000
     data_alerts_path: The json path to find alert data. Default to "alerts"
                       Use empty string "" to treat the whole payload data as

tests/integration/event_source_webhook/test_webhook_source.py

@@ -40,7 +40,7 @@ def test_webhook_source_sanity(subprocess_teardown, port: int):
         json.dumps({"shutdown": ""}).encode("ascii"),
     ]
 
-    url = f"http://127.0.0.1:{port}/webhook"
+    url = f"http://localhost:{port}/webhook"
 
     env = os.environ.copy()
     env["WH_PORT"] = str(port)
@@ -66,7 +66,7 @@ def test_webhook_source_sanity(subprocess_teardown, port: int):
         stdout, _unused_stderr = proc.communicate()
 
     assert "Rule fired successfully" in stdout.decode()
-    assert f"'Host': '127.0.0.1:{port}'" in stdout.decode()
+    assert f"'Host': 'localhost:{port}'" in stdout.decode()
     assert proc.returncode == 0
 
 
@@ -105,7 +105,7 @@ def test_webhook_source_hmac_sanity(subprocess_teardown):
     ]
 
     port = 5000
-    url = f"http://127.0.0.1:{port}/webhook"
+    url = f"http://localhost:{port}/webhook"
 
     env = os.environ.copy()
     env["WH_PORT"] = str(port)
@@ -132,7 +132,7 @@ def test_webhook_source_hmac_sanity(subprocess_teardown):
         stdout, _unused_stderr = proc.communicate()
 
     assert "Rule fired successfully" in stdout.decode()
-    assert f"'Host': '127.0.0.1:{port}'" in stdout.decode()
+    assert f"'Host': 'localhost:{port}'" in stdout.decode()
     assert proc.returncode == 0
 
 

tests/unit/event_source/test_alertmanager.py

@@ -29,7 +29,7 @@ async def cancel_code(server_task):
 async def test_cancel():
     queue = asyncio.Queue()
 
-    args = {"host": "127.0.0.1", "port": 8001}
+    args = {"host": "localhost", "port": 8001}
     plugin_task = asyncio.create_task(start_server(queue, args))
     cancel_task = asyncio.create_task(cancel_code(plugin_task))
 
@@ -41,7 +41,7 @@ async def test_cancel():
 async def test_post_endpoint_with_default():
     queue = asyncio.Queue()
 
-    args = {"host": "127.0.0.1", "port": 8002}
+    args = {"host": "localhost", "port": 8002}
     plugin_task = asyncio.create_task(start_server(queue, args))
 
     task_info = {
@@ -86,7 +86,7 @@ async def test_post_endpoint_with_options():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8003,
         "data_alerts_path": "",
         "data_host_path": "node",

tests/unit/event_source/test_webhook.py

@@ -52,7 +52,7 @@ async def cancel_code(server_task):
 async def test_cancel():
     queue = asyncio.Queue()
 
-    args = {"host": "127.0.0.1", "port": 8000, "token": "secret"}
+    args = {"host": "localhost", "port": 8000, "token": "secret"}
     plugin_task = asyncio.create_task(start_server(queue, args))
     cancel_task = asyncio.create_task(cancel_code(plugin_task))
 
@@ -64,7 +64,7 @@ async def test_cancel():
 async def test_post_endpoint():
     queue = asyncio.Queue()
 
-    args = {"host": "127.0.0.1", "port": 8000, "token": "secret"}
+    args = {"host": "localhost", "port": 8000, "token": "secret"}
     plugin_task = asyncio.create_task(start_server(queue, args))
 
     task_info = {
@@ -86,7 +86,7 @@ async def test_post_endpoint():
 @pytest.mark.asyncio
 async def test_post_unsupported_body():
     queue = asyncio.Queue()
-    args = {"host": "127.0.0.1", "port": 8000}
+    args = {"host": "localhost", "port": 8000}
 
     async def do_request():
         async with aiohttp.ClientSession() as session:
@@ -105,7 +105,7 @@ async def test_post_hmac_hex_endpoint():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "hmac_secret": "secret",
         "hmac_algo": "sha256",
@@ -138,7 +138,7 @@ async def test_post_hmac_hex_wo_digest_prefix_endpoint():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "hmac_secret": "secret",
         "hmac_algo": "sha256",
@@ -171,7 +171,7 @@ async def test_post_hmac_hex_endpoint_invalid_signature():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "hmac_secret": "secret",
         "hmac_algo": "sha256",
@@ -201,7 +201,7 @@ async def test_post_hmac_hex_endpoint_missing_signature():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "hmac_secret": "secret",
         "hmac_algo": "sha256",
@@ -231,7 +231,7 @@ async def test_post_hmac_base64_endpoint():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "hmac_secret": "secret",
         "hmac_algo": "sha256",
@@ -264,7 +264,7 @@ async def test_post_hmac_base64_endpoint_invalid_signature():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "hmac_secret": "secret",
         "hmac_algo": "sha256",
@@ -294,7 +294,7 @@ async def test_post_token_and_hmac_hex_endpoint():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "token": "secret",
         "hmac_secret": "secret",
@@ -326,7 +326,7 @@ async def test_post_token_and_hmac_hex_endpoint_invalid_signature():
     queue = asyncio.Queue()
 
     args = args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "token": "secret",
         "hmac_secret": "secret",
@@ -356,7 +356,7 @@ async def test_post_token_and_hmac_hex_endpoint_invalid_token():
     queue = asyncio.Queue()
 
     args = {
-        "host": "127.0.0.1",
+        "host": "localhost",
         "port": 8000,
         "token": "secret",
         "hmac_secret": "secret",