Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Ansible Big PR review days & Office Hours #407

Closed
gundalow opened this issue Nov 21, 2018 · 68 comments
Closed

Ansible Big PR review days & Office Hours #407

gundalow opened this issue Nov 21, 2018 · 68 comments
Labels
contributor_experience https://github.com/ansible/community/wiki/Contributor%20Experience

Comments

@gundalow
Copy link
Contributor

gundalow commented Nov 21, 2018

Ask not what your community can do for you, ask what you can do for your community!

What are we doing and why?

Ansible is a very popular project by any metric. Our awesome community contributes lots of Pull Requests (PRs) every month. Unfortunately, the volume of incoming PRs means contributors often have to wait a looong time for PRs to be merged, or even reviewed. We want to change that.

The Core Team and Community at large is starting various initiatives under the Contributor Experience umbrella to help address some of the root causes that slow down quality PRs from being merged into Ansible.
We dedicate one day a month to doing a big community review. We hope you can join in!

What we are trying to achieve

  • To give potential new community members a place to learn and experiment with Ansible's review process and get feedback
  • Improve the process and documentation by getting feedback from you
    • Feedback from people starting their journey with open source is particularly important to us as it helps to identify and improve complicated processes and documentation.
    • People that have been contributing for a while have already built up this knowledge and have forgotten the "pain of getting started"
  • Give PRs some love
  • Identify PRs that could be merged or closed
  • Help PRs that are not covered by one of the existing Ansible Working Groups, and therefore may otherwise fall through the cracks

How

  • Using a few (to be defined) GitHub searches we will go through PRs and:

    • Provide feedback, which is useful to the PR author
    • Provide testing feedback, which will help maintainers know if it can be merged
    • Merge if good
    • Close, if not needed
  • For collections we will be focusing on

When

  • Thursday 29th November 2018 from 0900 UTC till late
  • Wednesday 19th December 2018 from 0900 UTC till late
  • Tuesday 3rd September from 1000UTC til late
  • Thursday 19th September from 1000UTC til late
  • Thursday 14th November from 1400UTC til late
  • Wednesday 17th June from 1400UTC til late
  • Tuesday 1st December 2020 1500UTC
  • Thursday 17th December 2020 In my timezone, and calendar invitation

Add to your calendar by clicking the Add to Calendar in the above links

What do I need

Even if you are new to contributing to Ansible, this is an excellent opportunity to get involved!

Our IRC channels may require you to register your nickname. If you receive an error when you connect, see Freenode’s Nickname Registration guide for instructions.

@gundalow gundalow added the contributor_experience https://github.com/ansible/community/wiki/Contributor%20Experience label Nov 21, 2018
@gundalow

This comment has been minimized.

@larsks

This comment has been minimized.

@gregdek

This comment has been minimized.

@Shaps

This comment has been minimized.

1 similar comment
@robertdebock

This comment has been minimized.

@resmo

This comment has been minimized.

@varunchopra

This comment has been minimized.

2 similar comments
@davegarath

This comment has been minimized.

@apple4ever

This comment has been minimized.

@mbhavya

This comment has been minimized.

1 similar comment
@barlik

This comment has been minimized.

@felixfontein

This comment has been minimized.

@abstract-base-method

This comment has been minimized.

@alexsaezm

This comment has been minimized.

@biohazd

This comment has been minimized.

@acozine

This comment has been minimized.

@maxamillion

This comment has been minimized.

@winem

This comment has been minimized.

@gundalow

This comment has been minimized.

@rajeevarakkal

This comment has been minimized.

@Saurabh-Thakre

This comment has been minimized.

@richardcs

This comment has been minimized.

@gundalow

This comment has been minimized.

@Akasurde Akasurde unpinned this issue Apr 26, 2019
@gundalow
Copy link
Contributor Author

gundalow commented Aug 22, 2019

Given some discussion in #ansible-devel today, it was proposed that we should do PR review days fortnightly to help get the PR backlog under control.

Looking at the last three months for ansible/ansible:

  • 908 PRs created
  • 830 PRs merged (or closed without merging)
  • Difference: 78/month

So if we can process another 80 PRs/month then we can keep the backlog stead (or better yet decreasing) [1]

.

  • Alternate between different days of the week to give people a reasonable chance of attending
  • Publicise the dates well in advance (ie just set the dates for the next n-months)
  • Work through different GitHub PR queries each time, so give a reasonable chance of hiting different PRs
  • Also advertise this as a dropin place for "can you help review my PR"
  • Flesh this into a blog post to help recruit/promote

To avoid too much email spam, how about people vote on this issues:
❤️ This sounds like a good idea, lets see how it works out
and/or
👍 I may be able to attend occasionally to help out.

or
👎 I don't think this is a good idea

Join the discussion in '#ansible-community on Freenode

[1] Yes, yes, I know it doesn't really work like that, and things very from month to month, though the point is that ~10% increase in merge/close rate will let us breakeven

@gundalow gundalow pinned this issue Aug 22, 2019
@tremble

This comment has been minimized.

@gundalow

This comment has been minimized.

@gundalow

This comment has been minimized.

@gundalow
Copy link
Contributor Author

Starting now in #ansible-community on Freenode IRC

@gundalow

This comment has been minimized.

@gundalow
Copy link
Contributor Author

Starting in just under 3 hours, see you in #ansible-community on Freenode.

@gundalow

This comment has been minimized.

@gundalow
Copy link
Contributor Author

gundalow commented Jun 7, 2020

Hi all.
The next PR day will be Wednesday 17th June 2020 from 1400UTC

When

Wednesday 17th June 2020 from 1400UTC

What's this in my Timezone?

Where

#ansible-community on Freenode IRC

What

This will be our first session focusing on the new Community Collections:

@gundalow
Copy link
Contributor Author

Starting now in #ansible-community

@gundalow gundalow unpinned this issue Jun 25, 2020
@gundalow
Copy link
Contributor Author

Next two PR days

Please give a 👍 on this issue if you can attend either

@gundalow gundalow changed the title Monthly Big PR review Ansible Big PR review days Nov 19, 2020
@gundalow gundalow changed the title Ansible Big PR review days Ansible Big PR review days & Office Hours Nov 19, 2020
@gundalow
Copy link
Contributor Author

Reminder that this is taking place tomorrow, Tuesday 1st December 2020 1500UTC In my timezone, and calendar invitation

@gundalow
Copy link
Contributor Author

gundalow commented Dec 1, 2020

About to start in #ansible-community on Freenode IRC

@prantikb
Copy link

I'll be there

@ggold7046
Copy link

ggold7046 commented Dec 19, 2022

Hi,I'm new to open source. Could anyone guide me to good first issues ?

@ggold7046
Copy link

@maxamillion , could you help me please ?

@Andersson007
Copy link
Contributor

Andersson007 commented Jan 6, 2023

@ggold7046 hello, apologies for the late reply (long end-of-year PTOs) and welcome to the project!

Please:

Thanks for your interest in contributing to ansible!

@maxamillion
Copy link
Contributor

@ggold7046 what @Andersson007 said! (Double apologies for not replying sooner ... I'm still not caught up on email because I took a whole month off for the winter holidays 😄)

@ggold7046
Copy link

ggold7046 commented Jan 27, 2023 via email

@Andersson007
Copy link
Contributor

@ggold7046 you could take a look at easifixes:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor_experience https://github.com/ansible/community/wiki/Contributor%20Experience
Projects
None yet
Development

No branches or pull requests