Conversation
|
| editable=False, | ||
| ) | ||
| capacity_adjustment = models.DecimalField(default=Decimal(1.0), max_digits=3, decimal_places=2, validators=[MinValueValidator(0)]) | ||
| capacity_adjustment = models.DecimalField(default=Decimal(1.0), max_digits=3, decimal_places=2, validators=[MinValueValidator(Decimal(0.0))]) |
There was a problem hiding this comment.
Does this not require a new migration file?
There was a problem hiding this comment.
bash-5.1$ awx-manage makemigrations
No changes detected
Does not appear so
There was a problem hiding this comment.
Don't think it actually changes the datatype, but rather validator function in Django
There was a problem hiding this comment.
validators had some weird place in both the fields and the model Meta. Weird but possible.
kdelee
force-pushed
the
min-value-decimal
branch
from
ba37d71 to
80c179d
Compare
|
A test could be nice too. |
kdelee
force-pushed
the
min-value-decimal
branch
2 times, most recently
from
20a1df2 to
9ee487d
Compare
|
This hopefully resolves error message seen in logs sometimes about "should be Decimal type"
AlanCoding
force-pushed
the
min-value-decimal
branch
from
9ee487d to
2e9a9aa
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
2 participants
This hopefully resolves error message seen in logs sometimes about "should be Decimal type"
ISSUE TYPE
COMPONENT NAME