-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helm chart code #1938
Remove Helm chart code #1938
Conversation
@@ -255,195 +239,3 @@ catalog-build: opm ## Build a catalog image. | |||
.PHONY: catalog-push | |||
catalog-push: ## Push a catalog image. | |||
$(MAKE) docker-push IMG=$(CATALOG_IMG) | |||
|
|||
.PHONY: kubectl-slice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not helm specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I'll revert this but wanted to note that this section and the other section that begins with the line .PHONY: yq
were added as part of the initial Helm functionality commit: efaa471#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I think we should remove both yq
and kubectl-slice
since they are not used for anything other than generating Helm charts 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kurokobo is correct lets remove yq and kubectl-slice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheRealHaoLiu This should be fixed now. Thanks again @kurokobo
This reverts commit da38360.
When all the checks are passed, we can probably merge this. The corresponding bits are now available from the main branch of the community repo: https://github.com/ansible-community/awx-operator-helm/tree/main |
Where do I go to install the chart now?
|
@nmoseman Hi, please try from https://ansible-community.github.io/awx-operator-helm/ - if you have any difficulties / encounter problems please let us know! |
Hi, I also had to change to the new url this morning & everything is ok now once I found this PR. Anyway, thanks for all the work 👍 |
This page will be removed by this PR 🤔 |
* rm Helm chart starter directory * rm Helm release playbook * rm Helm install from docs * rm Helm chart workflows * rm Helm starter from yamllint * rm Helm targets from Makefile * Revert "rm Helm targets from Makefile" This reverts commit da38360. * remove helm from Makefile * rm kubectl-slice and yp from Makefile
SUMMARY
Following on from the announcement to relocate Helm chart code for the AWX Operator to the
ansible-community/awx-operator-helm
repository, this PR moves remove files related to the Helm chart.Do not merge until after the following PRs are integrated in the new repo:
ISSUE TYPE
ADDITIONAL INFORMATION
When the commits are added to the new repo, we should delete the
gh-pages
branch here. I don't have sufficient permissions to delete branches here though.