Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Helm chart code #1938

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Remove Helm chart code #1938

merged 9 commits into from
Aug 8, 2024

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Aug 6, 2024

SUMMARY

Following on from the announcement to relocate Helm chart code for the AWX Operator to the ansible-community/awx-operator-helm repository, this PR moves remove files related to the Helm chart.

Do not merge until after the following PRs are integrated in the new repo:

ISSUE TYPE
  • Breaking Change
ADDITIONAL INFORMATION

When the commits are added to the new repo, we should delete the gh-pages branch here. I don't have sufficient permissions to delete branches here though.

@@ -255,195 +239,3 @@ catalog-build: opm ## Build a catalog image.
.PHONY: catalog-push
catalog-push: ## Push a catalog image.
$(MAKE) docker-push IMG=$(CATALOG_IMG)

.PHONY: kubectl-slice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not helm specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I'll revert this but wanted to note that this section and the other section that begins with the line .PHONY: yq were added as part of the initial Helm functionality commit: efaa471#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I think we should remove both yq and kubectl-slice since they are not used for anything other than generating Helm charts 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurokobo is correct lets remove yq and kubectl-slice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealHaoLiu This should be fixed now. Thanks again @kurokobo

Makefile Show resolved Hide resolved
@oraNod
Copy link
Contributor Author

oraNod commented Aug 7, 2024

When all the checks are passed, we can probably merge this. The corresponding bits are now available from the main branch of the community repo: https://github.com/ansible-community/awx-operator-helm/tree/main

@nmoseman
Copy link

nmoseman commented Aug 7, 2024

Where do I go to install the chart now?

helm repo update
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "awx-operator" chart repository (https://ansible.github.io/awx-operator/):
	failed to fetch https://ansible.github.io/awx-operator/index.yaml : 404 Not Found
Update Complete. ⎈Happy Helming!⎈

@oraNod
Copy link
Contributor Author

oraNod commented Aug 7, 2024

Where do I go to install the chart now?

helm repo update
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "awx-operator" chart repository (https://ansible.github.io/awx-operator/):
	failed to fetch https://ansible.github.io/awx-operator/index.yaml : 404 Not Found
Update Complete. ⎈Happy Helming!⎈

@nmoseman Hi, please try from https://ansible-community.github.io/awx-operator-helm/ - if you have any difficulties / encounter problems please let us know!

@MrLuje
Copy link

MrLuje commented Aug 8, 2024

Hi, I also had to change to the new url this morning & everything is ok now once I found this PR.
I first checked https://ansible.readthedocs.io/projects/awx-operator/en/latest/installation/helm-install-on-existing-cluster.html if the repo url changed and is not up-to-date yet, don't forget it ;)

Anyway, thanks for all the work 👍

@kurokobo
Copy link
Contributor

kurokobo commented Aug 8, 2024

I first checked https://ansible.readthedocs.io/projects/awx-operator/en/latest/installation/helm-install-on-existing-cluster.html if the repo url changed and is not up-to-date yet, don't forget it ;)

This page will be removed by this PR 🤔

@TheRealHaoLiu TheRealHaoLiu merged commit f0a518b into ansible:devel Aug 8, 2024
7 checks passed
grechaw pushed a commit to LexMachinaInc/awx-operator that referenced this pull request Aug 19, 2024
* rm Helm chart starter directory

* rm Helm release playbook

* rm Helm install from docs

* rm Helm chart workflows

* rm Helm starter from yamllint

* rm Helm targets from Makefile

* Revert "rm Helm targets from Makefile"

This reverts commit da38360.

* remove helm from Makefile

* rm kubectl-slice and yp from Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants