Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_domain_user: do not hide error on failures (#58357) - 2.8 #58611

Merged
merged 1 commit into from
Jul 16, 2019
Merged

win_domain_user: do not hide error on failures (#58357) - 2.8 #58611

merged 1 commit into from
Jul 16, 2019

Conversation

jborean93
Copy link
Contributor

(cherry picked from commit c260721)

SUMMARY

Backport of #58357

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain_user

@jborean93
win_domain_user: do not hide error on failures (ansible#58357)
92e9e83 
* win_domain_user: do not hide error on failures

* Was a bit too overzealous in the removal

* Remove uneeded sanity ignore rule

(cherry picked from commit c260721)
@jborean93 jborean93 mentioned this pull request Jul 1, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Jul 1, 2019

cc @ShachafGoldstein @if-meaton @jhawkesworth @mattclay @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Jul 1, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2019
@abadger abadger merged commit 014b7ec into ansible:stable-2.8 Jul 16, 2019
@abadger
Copy link
Contributor

abadger commented Jul 16, 2019

Merged for the 2.8.3 release

@jborean93 jborean93 deleted the win_domain_user-exp-2.8 branch July 16, 2019 19:28
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 22, 2019
@ansible ansible locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jborean93 @ansibot @abadger @sivel