pkgutil: add update all, check-mode, squashing and examples #51651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perations, option to use force mode, more examples
ansibot
added
affects_2.8
dagwieers
force-pushed
the
scathatheworm-devel
branch
from
4e84827 to
db81d31
Compare
|
I added integration tests, but they have not been tested (lacking any Solaris systems). Please test these changes by doing: $ ansible-test integration --allow-unsupported --allow-destructive pkgutil -vPS The integration tests are considered destructive because it may remove CWStop when not run successfully. So be aware. |
dagwieers
force-pushed
the
scathatheworm-devel
branch
from
db81d31 to
514cb1f
Compare
ansibot
added
the
support:community
mattclay
previously requested changes
Feb 4, 2019
ansibot
added
needs_revision
mattclay
dismissed
their stale review
Review comments addressed. Remainder of PR not reviewed.
ansibot
removed
the
needs_revision
ansibot
added
community_review
ansibot
added
the
stale_ci
I found that I also needed to pass |
mavit
reviewed
Feb 15, 2019
|
@mavit Can you test again ? Does the integration test work out-of-the-box ? I wasn't expecting it to be perfect, but I cannot test myself. |
|
Any tests that require |
ansibot
added
packaging
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
ansibot
added
collection
ansibot
added
the
needs_triage
|
Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.general. Please re-submit this issue in the above repository. If you have further questions please stop by IRC or the mailing list:
|
mkrizek
removed
the
needs_triage
mavit
added a commit
to mavit/community.general
that referenced
this pull request
Aug 18, 2020
Taken from ansible/ansible#51651 by dagwieers, which was taken from ansible/ansible#27866 by scathatheworm. Let’s have one last attempt to get this merged. > ##### SUMMARY > > Original PR #27866 from scathatheworm > > When working with Solaris pkgutil CSW packages, I came across this module being very basic in functionality, in particular, that I could not use it to update all CSW packages. > > When going into details into the code I also found it did not incorporate a possibility of doing dry-run from the underlying utility, or supported to specify multiple packages for operations. > > This module probably sees very little use, but it seemed like nice functionality to add and make it behave a little more like other package modules. > ##### ISSUE TYPE > > * Feature Pull Request > > > ##### COMPONENT NAME > > pkgutil module > ##### ANSIBLE VERSION > > ``` > ansible 2.3.1.0 > config file = /etc/ansible/ansible.cfg > configured module search path = Default w/o overrides > python version = 2.7.5 (default, Aug 2 2016, 04:20:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)] > ``` > > ##### ADDITIONAL INFORMATION > > * Added ability to upgrade all packages: > > > ```yaml > - pkgutil: > name: '*' > state: latest > ``` > > * Added ability to modify state of a list of packages: > > > ```yaml > - pkgutil: > name: > - CSWtop > - CSWwget > - CSWlsof > state: present > ``` > > * Added ability to have underlying tool perform a dry-run when using check mode, pkgutil -n > > * Added ability to configure force option to force packages to state determined by repository (downgrade for example) > > > ```yaml > - pkgutil: > name: CSWtop > state: latest > force: yes > ``` > > * Added more examples and documentation to show the new functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Original PR #27866 from @scathatheworm
When working with Solaris pkgutil CSW packages, I came across this module being very basic in functionality, in particular, that I could not use it to update all CSW packages.
When going into details into the code I also found it did not incorporate a possibility of doing dry-run from the underlying utility, or supported to specify multiple packages for operations.
This module probably sees very little use, but it seemed like nice functionality to add and make it behave a little more like other package modules.
ISSUE TYPE
COMPONENT NAME
pkgutil module
ANSIBLE VERSION
ADDITIONAL INFORMATION
Added ability to have underlying tool perform a dry-run when using check mode, pkgutil -n
Added ability to configure force option to force packages to state determined by repository (downgrade for example)