win_regedit: added function to load a dat file for editing #31289
Conversation
ansibot
added
affects_2.5
| Fail-Json -obj $result -message "hive at path '$hive' is not valid or accessible, cannot load hive" | ||
| } | ||
| if (Test-Path -Path HKLM:\ANSIBLE) { | ||
| Fail-Json -obj $result -message "hive already loaded at HKLM:\ANSIBLE, cannot load another hive until this is manually unloaded" |
There was a problem hiding this comment.
This to me is problematic. We can end up in a situation where the only way to get out of this is to do something outside of Ansible. Ideally it would only be loaded within its own context, and automatically unloaded.
I wonder if we could either make this path unique to the session, and have a clean-up function for older sessions.
There was a problem hiding this comment.
We could make the path unique but would need more complex handling around how someone would set the path. This isn’t too much of an issue as keys can’t be created at the root folder and this would only fire if a hive has been manually loaded before.
I’ll let others comment on this before changing though as I traded convenience for simpler code in this case.
There was a problem hiding this comment.
Hey @dagwieers, I've updated the code so that it will unload the hive if it has been set and output a warning if this happens.
There was a problem hiding this comment.
That's very useful, but doesn't mitigate the possibility of conflicts, so maybe a better implementation (in time) is warranted. Maybe adding a note in the code wrt. this.
Is the unloading of a hive guaranteed to work, or could it fail when in use ?
There was a problem hiding this comment.
We will want to make the decision before merging this in as it would affect what the user would put in their path. In the current case the hive is accessed with HKLM:\ANSIBLE\* while in your suggestion it would come under its own root. I'm not even sure if you can create a Registry PSDrive and map it to a subkey on an existing drive.
As with all things it can fail, the main reason would be if someone had loaded the hive manually before hand and still had a handle open to it. Even if we were to use unique names you cannot load a hive file again once it has been loaded once under a different name.
There was a problem hiding this comment.
Ouch, if it can only be loaded once... This is fine by me.
ansibot
added
needs_revision
ansibot
added
the
stale_ci
jborean93
force-pushed
the
win_regedit-hive
branch
from
5e94183
to
52fff14
Compare
ansibot
removed
the
stale_ci
|
CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/40723/8/tests |
mattclay
added
the
ci_verified
ansibot
added
core_review
jborean93
force-pushed
the
win_regedit-hive
branch
from
58146ba
to
ba737fa
Compare
ansibot
added
feature
SUMMARY
Feature for #20123. Allows a user to specify a registry hive to load so it can be manipulated with
win_regedit. When specified the hive is always loaded at the fixed position ofHKLM:\ANSIBLE.ISSUE TYPE
COMPONENT NAME
win_regedit
ANSIBLE VERSION