Skip to content

docker images - update environment variables #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 20, 2023
Merged

docker images - update environment variables #927

merged 7 commits into from
Sep 20, 2023

Conversation

@jamestalton
Copy link
Contributor

@jamestalton jamestalton commented Sep 20, 2023 •
edited
Loading

  • Update the docker images to use the SERVER env variable instead of PROTOCOL and HOST.
  • Update to use https instead of http
    • needed for sso auth
    • needed for websockets on https servers

@github-actions github-actions bot added the AFW Ansible Framework label Sep 20, 2023
@jamestalton
fis guthub action
7ad7b4d 
Signed-off-by: James Talton <[email protected]>
@jamestalton
fix github action
d2de48f 
Signed-off-by: James Talton <[email protected]>
@jamestalton
fix test
829bc8c 
Signed-off-by: James Talton <[email protected]>
@github-actions github-actions bot added the E2E End-to-end testing label Sep 20, 2023
@jamestalton jamestalton merged commit c447da7 into main Sep 20, 2023
@jamestalton jamestalton deleted the docker-images---update-environment-variables branch September 20, 2023 19:23
@kurokobo kurokobo mentioned this pull request Sep 26, 2023
Closed
@kurokobo kurokobo mentioned this pull request Oct 14, 2023
Merged
@rooftopcellist rooftopcellist mentioned this pull request Oct 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithjgrant keithjgrant keithjgrant approved these changes

+1 more reviewer

@vishsanghishetty vishsanghishetty vishsanghishetty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AFW Ansible Framework E2E End-to-end testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamestalton @keithjgrant @vishsanghishetty