Remove docstring first check from pre-commit #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
requested review from
ssbarnea,
webknjaz,
priyamsahoo,
alisonlhart and
thedoubl3j
relrod
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It conflicts when the PEP257 attribute naming convention is used to document either a
TypeAliasorNewType.Related: pre-commit/pre-commit-hooks#159
String literals occurring immediately after a simple assignment at the top level of a module, class, or __init__ method are called "attribute docstrings".Ref: https://www.python.org/dev/peps/pep-0257/#id4
As seen here: https://results.pre-commit.ci/run/github/320052445/1646080610.D81bOX7LQLakCKvAoaxx_A
because of:
https://github.com/ansible/ansible-navigator/pull/1024/files#diff-876f32fdc126136789ecfd4484fd9e4950a5faf7fb8fa3cefcff7ac6f6b7ac50R27