-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve feedback for fix
, avoid a traceback with transform
#4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
May 13, 2024
ssbarnea
added a commit
that referenced
this pull request
May 13, 2024
ssbarnea
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linting the following repo: https://github.com/anshulbehl/ilo-ansible-collection
If was found that if
ANSIBLE_LINT_NODEPS
was enabled to bypass the missing plugins and roles, the fixing of files would traceback and stop immediately.This PR both improves the debug and error messages during fix as well as avoids the traceback so file processing can continue.
The messages were set as constants to limit tight coupling to messages in the tests.
Fixing may be able to be improved if further time was spent with the above repo in the future.
Note: The precommit ruff version was set to the latest to catch some errors found locally
Messages will now appear like this: