Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue linting other files when one has syntax-check errors #4133

Merged
merged 1 commit into from
May 7, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 5, 2024

Syntax-errors will no longer prevent the linter from checking other rules in other files.

Fixes: #4122

@ssbarnea ssbarnea requested a review from audgirka May 5, 2024 18:58
@github-actions github-actions bot added the bug label May 5, 2024
This is a notable change in behavior as from now syntax-errors will
no longer prevent the linter from checking other rules in other files.

Fixes: #4122
@ssbarnea ssbarnea changed the title Run entire linting regardless if syntax-check errors are found Continue linting other files when one has syntax-check errors May 6, 2024
@ssbarnea ssbarnea requested a review from Qalthos May 6, 2024 09:51
@ssbarnea ssbarnea merged commit 6cf0f96 into main May 7, 2024
24 of 25 checks passed
@ssbarnea ssbarnea deleted the fix/syntax-check branch May 7, 2024 07:45
@ssbarnea ssbarnea added major Used for release notes, requires major versioning bump and removed bug labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Used for release notes, requires major versioning bump
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Undefined output when hitting unknown-module
2 participants