Allow dashes in legacy role namespaces #3962
Conversation
sur5r
requested review from
ssbarnea and
shatakshiiii
and removed request for
a team
|
Can you please also update the link to documentation to a valid page that documents the new namespace requirements? |
|
Unfortunately, I have no idea where this is documented. I have to admit that I have spent way too many hours fighting windmills around this galaxy vs. galaxy-ng vs. namespaces vs. legacy namespaces vs. dash-to-underscore-to-dash-to-dot-conversion disaster. I fully understand if you don't want to merge this without proper docs and or tests, but I'm completely lost here. |
|
It's not documented in the narrative style but it is encoded into galaxy-importer's legacy role validation code. https://github.com/ansible/galaxy-importer/blob/master/galaxy_importer/loaders/legacy_role.py#L57-L61 Galaxy must support every possible github username as a namespace name for legacy roles. This is because galaxy was originally meant to be an index of github, not an artifactory competitor. It was collections that started morphing galaxy into something different from it's original intent and once the team started trying to fudge all the constraints of collections onto roles that things got fuzzy. That is why at some point they attempted to convert all namespace hyphens to underscores, which turned out to be a big mistake. Now we're left with a mix of role namespaces that don't quite map to their github usernames. GalaxyNG's implementation sought to eliminate the confusion by separating collection and role namespaces. Now the role namespaces can continue to have hyphens (and underscores because of the historical mistake) and map to the true github usernames as they were always meant to. Collection namespaces can not have hyphens and will never be able to because of how the ansible-core architecture uses them via python imports. In summary, this change is good as long as it's only changing it for standalone/legacy roles. |
ssbarnea
changed the title
|
@sur5r You failed to update a fixture and it seems that I am not allowed to push the fix to your branch. There is a checkbox in the right sidebar for allowing others to push to your PR. |
|
The "Allow edits by maintainers" checkbox is checked. I cherry-picked your commit onto my branch. Thank you very much for moving this forward! |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.22.1` -> `==6.22.2` | --- ### Release Notes <details> <summary>ansible/ansible-lint (ansible-lint)</summary> ### [`v6.22.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.22.2) [Compare Source](ansible/ansible-lint@v6.22.1...v6.22.2) #### Bugfixes - Fix key error for name\[casing] rule ([#​3987](ansible/ansible-lint#3987)) [@​ajinkyau](https://github.com/ajinkyau) - Allow dashes in legacy role namespaces ([#​3962](ansible/ansible-lint#3962)) [@​sur5r](https://github.com/sur5r) - Use new ansible-compat verbosity levels ([#​3975](ansible/ansible-lint#3975)) [@​ssbarnea](https://github.com/ssbarnea) - Remove dependency on newer requests library ([#​3959](ansible/ansible-lint#3959)) [@​ssbarnea](https://github.com/ssbarnea) - Ignore set-property for systemd command ([#​3949](ansible/ansible-lint#3949)) [@​alanbbr](https://github.com/alanbbr) - Correct requires_ansible error message ([#​3954](ansible/ansible-lint#3954)) [@​ssbarnea](https://github.com/ssbarnea) - Improve transformation for `no-free-form` rule ([#​3945](ansible/ansible-lint#3945)) [@​ajinkyau](https://github.com/ajinkyau) - Documentation improvement ([#​3946](ansible/ansible-lint#3946)) [@​ssbarnea](https://github.com/ssbarnea) - docs: fix grammatical issue in philosophy Q\&A section ([#​3934](ansible/ansible-lint#3934)) [@​davidhulick](https://github.com/davidhulick) - Update supported versions of ansible ([#​3930](ansible/ansible-lint#3930)) [@​ajinkyau](https://github.com/ajinkyau) - Fix backward compatibility ([#​3929](ansible/ansible-lint#3929)) [@​McSim85](https://github.com/McSim85) - Fix auto capitalization for name\[prefix] rule ([#​3922](ansible/ansible-lint#3922)) [@​ajinkyau](https://github.com/ajinkyau) - Fix role deps check for detecting path names ([#​3923](ansible/ansible-lint#3923)) [@​cavcrosby](https://github.com/cavcrosby) - Avoid warnings about PATH with pipx installations ([#​3920](ansible/ansible-lint#3920)) [@​ssbarnea](https://github.com/ssbarnea) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/319 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Fixes: #3961