Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git a runtime dependency #2860

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Make git a runtime dependency #2860

merged 1 commit into from
Jan 1, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jan 1, 2023

As we received numerous bug reports which proved to be caused by
the missing git, we make git a permanent runtime dependency. This will
make the tool behavior more consistent as before that behavior would
have being different if git was missing.

@ssbarnea ssbarnea requested a review from a team as a code owner January 1, 2023 12:54
@github-actions github-actions bot added the bug label Jan 1, 2023
@ssbarnea ssbarnea force-pushed the fix/require-git branch 2 times, most recently from e282f75 to fb4e2cf Compare January 1, 2023 15:18
As we received numerous bug reports which proved to be caused by
the missing git, we make git a permanent runtime dependency. This will
make the tool behavior more consistent as before that behavior would
have being different if git was missing.
@ssbarnea ssbarnea merged commit ad79bff into main Jan 1, 2023
@ssbarnea ssbarnea deleted the fix/require-git branch January 1, 2023 16:04
FuzzyMistborn added a commit to FuzzyMistborn/docker-linting that referenced this pull request Feb 6, 2023
@fclaerho
Copy link
Contributor

fclaerho commented May 31, 2023

Hi @ssbarnea !

I just hit this weird case of installing innocently ansible-lint in a minimal python docker image to lint a playbook, and having it fail flat with this:

# pipenv run ansible-lint -vv --parseable --skip-list fqcn-builtins,unnamed-task,key-order playbook.yml
…
Failed to find runtime dependency 'git' in PATH

I've traced back this error to this issue, which make "git" a required dependency of ansible-lint, a change very strange in itself (ansible-lint being a Python tool initially, now we have a non-python dependency -- the above ticket description refers to git-related issues, could this be detailed?) — and as importantly it's simply not documented anywhere in the installation page (and indeed the change list above only covers the code):
https://ansible-lint.readthedocs.io/installing/

Could this new requirement be added to the doc? (or am I missing something?)

@ssbarnea
Copy link
Member Author

Hi! Shotly, there is no need to add it to the docs because we have an incoming change that will remove the need for git executable.

@fclaerho
Copy link
Contributor

Good to know, thanks for the info 👍🏻

@ssbarnea
Copy link
Member Author

@fclaerho Take a look at #3507 and test if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants