Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If project_dir is passed, locate requirements within that directory #339

Merged
merged 10 commits into from
Feb 12, 2024
Merged

If project_dir is passed, locate requirements within that directory #339

merged 10 commits into from
Feb 12, 2024

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Nov 21, 2023 •
edited
Loading

When custom directory is passed using project_dir,
use it to locate the requirements file within that project_dir
and install dependencies.
Related: #3683

@audgirka audgirka requested a review from a team as a code owner November 21, 2023 10:28
@audgirka audgirka requested review from cristianonicolai and shatakshiiii and removed request for a team November 21, 2023 10:28
@audgirka audgirka changed the title If project_dir is passed, locate requirements within that directory If project_dir is passed, locate requirements within that directory Nov 21, 2023
@audgirka audgirka changed the title If project_dir is passed, locate requirements within that directory If project_dir is passed, locate requirements within that directory Nov 21, 2023
@audgirka audgirka added the bug Something isn't working label Nov 21, 2023
@audgirka audgirka mentioned this pull request Nov 21, 2023
Closed
@ssbarnea ssbarnea marked this pull request as draft November 27, 2023 13:27
@audgirka audgirka marked this pull request as ready for review January 29, 2024 10:10
@audgirka
Copy link
Contributor Author

audgirka commented Jan 29, 2024 •
edited
Loading

@ssbarnea @Qalthos How would molecule be impacted by this change?

@ssbarnea ssbarnea merged commit 23c030a into main Feb 12, 2024
25 checks passed
@ssbarnea ssbarnea deleted the fix/custom_root_dir branch February 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos

@cidrblock cidrblock Awaiting requested review from cidrblock

Assignees
No one assigned
Labels
bug Something isn't working
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@audgirka @ssbarnea