Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more control over verbosity when calling ansible-galaxy #278

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

ziegenberg
Copy link
Contributor

This makes ansible-galaxy display important info when the logging level is increased. This helps with debugging ansible-lint.

When using ansible-lint with maximum verbosity level (-vv), it currently only outputs:

INFO     Running ansible-galaxy role install -vr roles/requirements.yml --roles-path /root/.cache/ansible-compat/d499d0/roles
INFO     Running ansible-galaxy collection install -v -r collections/requirements.yml

Outputting the stdout will help with debugging the installation of requirements.

@ziegenberg ziegenberg requested a review from a team as a code owner May 23, 2023 10:59
@ziegenberg ziegenberg force-pushed the verbose-requirements-install branch from bde85a2 to 9194b43 Compare May 23, 2023 11:04
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that we need to do something about it, we need to find a way to control verbosity from the consumer of compat library instead of harcoding the behavior.

@ziegenberg ziegenberg force-pushed the verbose-requirements-install branch from f109077 to c30bff0 Compare May 24, 2023 13:31
@ziegenberg
Copy link
Contributor Author

@ziegenberg ziegenberg force-pushed the verbose-requirements-install branch from c30bff0 to b37bd47 Compare May 24, 2023 13:39
@ziegenberg ziegenberg requested a review from ssbarnea May 24, 2023 13:55
@ziegenberg
Copy link
Contributor Author

@ssbarnea your thoughts on my proposed changes?

@ziegenberg
Copy link
Contributor Author

Hi @ssbarnea, any thoughts on my proposed changes?

…at INFO level

This makes ansible-galaxy display important info, when logging level is increased. This helps debugging ansible-lint.

Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
@ziegenberg ziegenberg force-pushed the verbose-requirements-install branch from 8906b6a to e14d45a Compare July 28, 2023 14:46
@ziegenberg
Copy link
Contributor Author

Hi @ssbarnea, any thoughts on my proposed changes?

I rebased my branch and solved the merge conflict.

@ziegenberg ziegenberg force-pushed the verbose-requirements-install branch from e14d45a to be2f4a6 Compare July 28, 2023 14:52
@ssbarnea ssbarnea changed the title invoke ansible-galaxy with increased verbosity and always log stdout at INFO level Allow more control over verbosity when calling ansible-galaxy Oct 30, 2023
@ssbarnea ssbarnea temporarily deployed to ack October 30, 2023 10:16 — with GitHub Actions Inactive
@ssbarnea ssbarnea added the bug Something isn't working label Oct 30, 2023
@ssbarnea ssbarnea temporarily deployed to ack October 30, 2023 10:16 — with GitHub Actions Inactive
@ssbarnea ssbarnea enabled auto-merge (squash) January 3, 2024 13:44
@ssbarnea ssbarnea merged commit 00e6106 into ansible:main Jan 3, 2024
25 checks passed
@ziegenberg ziegenberg deleted the verbose-requirements-install branch January 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants