Conversation
Based on original implementation made by @cirdblock this will allow us to reuse schema tools across multiple project, especially as the lower level python-jsonschema project does not produce identical results between runs.
ganeshrn
approved these changes
May 23, 2022
priyamsahoo
approved these changes
May 23, 2022
cidrblock
approved these changes
May 23, 2022
Collaborator
cidrblock
left a comment
There was a problem hiding this comment.
Clever sorting method..... only because I learned about it the other day, if we ever need the others: https://docs.python.org/3/library/functools.html#functools.total_ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on original implementation made by @cidrblock this will allow us to reuse schema tools across multiple project, especially as the lower level python-jsonschema project does not produce identical results between runs.
The main reason for having our own wrapped on top of python-jsonschema project is that this library does not produce consistent results. Apparently the maintainer does not consider the need to always sort reported errors as needed, thus both ways (
validate()anditer_errors()) to retrieve them can produce variable results between subsequent runs even when all input data is identical.In follow-ups we will likely add a schema store class, so we will ensure we do not instantiate schemas more often than needed.
Related: