Skip to content

improve the presentation of the errors #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+237 −18
Merged

improve the presentation of the errors #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 133 additions & 15 deletions src/views/dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { AAPMcpToolDefinition } from "../openapi-loader.js";
import { renderHeader, getHeaderStyles } from "../header.js";
import { getLogIcon } from "./utils.js";

interface DashboardData {
allTools: AAPMcpToolDefinition[];
Expand All @@ -26,14 +27,32 @@ export const renderDashboard = (data: DashboardData): string => {
};
}

// Count tools by service
// Count tools by service and calculate log statistics
const serviceStats = allTools.reduce(
(acc, tool) => {
const service = tool.service || "unknown";
acc[service] = (acc[service] || 0) + 1;
if (!acc[service]) {
acc[service] = {
toolCount: 0,
logs: { err: 0, warn: 0, info: 0 },
};
}
acc[service].toolCount++;

// Count logs by severity for this tool
tool.logs.forEach((log) => {
const severity = log.severity.toLowerCase() as "err" | "warn" | "info";
if (severity === "err" || severity === "warn" || severity === "info") {
acc[service].logs[severity]++;
}
});

return acc;
},
{} as Record<string, number>,
{} as Record<
string,
{ toolCount: number; logs: { err: number; warn: number; info: number } }
>,
);

return `
Expand Down Expand Up @@ -205,6 +224,79 @@ export const renderDashboard = (data: DashboardData): string => {
.service-gateway { background: #4caf50; color: white; }
.service-galaxy { background: #ff9800; color: white; }
.service-unknown { background: #f44336; color: white; }

/* Service log display styles */
.services-with-logs {
display: flex;
flex-direction: column;
gap: 12px;
}
.service-detail {
display: flex;
align-items: center;
justify-content: space-between;
padding: 8px 0;
border-bottom: 1px solid #f1f1f1;
}
.service-detail:last-child {
border-bottom: none;
}
.service-logs {
display: flex;
gap: 8px;
align-items: center;
}
.log-count {
display: inline-block;
padding: 2px 6px;
border-radius: 8px;
font-size: 0.8em;
font-weight: bold;
text-decoration: none;
}
.log-count.clickable {
cursor: pointer;
transition: all 0.2s ease;
border: 1px solid transparent;
}
.log-count.clickable:hover {
transform: translateY(-1px);
box-shadow: 0 2px 4px rgba(0,0,0,0.2);
text-decoration: none;
}
.log-count.err {
background-color: #f8d7da;
color: #721c24;
}
.log-count.err.clickable:hover {
background-color: #f5c6cb;
color: #491217;
border-color: #f1b0b7;
}
.log-count.warn {
background-color: #fff3cd;
color: #856404;
}
.log-count.warn.clickable:hover {
background-color: #ffeaa7;
color: #533f03;
border-color: #ffe08a;
}
.log-count.info {
background-color: #d1ecf1;
color: #0c5460;
}
.log-count.info.clickable:hover {
background-color: #b8daff;
color: #004085;
border-color: #9fcdff;
}
.no-logs {
font-size: 0.8em;
color: #6c757d;
font-style: italic;
}

${getHeaderStyles()}
</style>
</head>
Expand Down Expand Up @@ -232,8 +324,9 @@ export const renderDashboard = (data: DashboardData): string => {
<div class="summary-number">${Object.keys(serviceStats).length}</div>
</div>
<div class="summary-card">
<h3>Categories</h3>
<div class="summary-number">${Object.keys(allCategories).length}</div>
<h3>Log Messages</h3>
<div class="summary-number">${Object.values(serviceStats).reduce((sum, service) => sum + service.logs.err + service.logs.warn + service.logs.info, 0)}</div>
<small>across all tools</small>
</div>
</div>

Expand Down Expand Up @@ -263,8 +356,8 @@ export const renderDashboard = (data: DashboardData): string => {
<div class="service-stats">
${Object.entries(serviceStats)
.map(
([service, count]) =>
`<span class="service-badge service-${service}">${service}: ${count}</span>`,
([service, stats]) =>
`<span class="service-badge service-${service}">${service}: ${stats.toolCount}</span>`,
)
.join("")}
</div>
Expand All @@ -286,20 +379,45 @@ export const renderDashboard = (data: DashboardData): string => {
<div class="stat-label">Services</div>
</div>
<div class="stat">
<div class="stat-number">${allTools.length}</div>
<div class="stat-number">${Object.values(serviceStats).reduce((sum, s) => sum + s.toolCount, 0)}</div>
<div class="stat-label">Total Tools</div>
</div>
<div class="stat">
<div class="stat-number">${Math.round(totalSize / 1000)}K</div>
<div class="stat-label">Characters</div>
<div class="stat-number">${Object.values(serviceStats).reduce((sum, s) => sum + s.logs.err, 0)}</div>
<div class="stat-label">${getLogIcon("err")} Errors</div>
</div>
<div class="stat">
<div class="stat-number">${Object.values(serviceStats).reduce((sum, s) => sum + s.logs.warn, 0)}</div>
<div class="stat-label">${getLogIcon("warn")} Warnings</div>
</div>
<div class="stat">
<div class="stat-number">${Object.values(serviceStats).reduce((sum, s) => sum + s.logs.info, 0)}</div>
<div class="stat-label">${getLogIcon("info")} Info</div>
</div>
</div>
<div class="service-stats">
<div class="services-with-logs">
${Object.entries(serviceStats)
.map(
([service, count]) =>
`<span class="service-badge service-${service}">${service}: ${count}</span>`,
)
.map(([service, stats]) => {
const hasLogs =
stats.logs.err > 0 ||
stats.logs.warn > 0 ||
stats.logs.info > 0;
return `
<div class="service-detail">
<span class="service-badge service-${service}">${service}: ${stats.toolCount} tools</span>
${
hasLogs
? `
<div class="service-logs">
${stats.logs.err > 0 ? `<a href="/services/${service}#logs" class="log-count err clickable">${getLogIcon("err")} ${stats.logs.err}</a>` : ""}
${stats.logs.warn > 0 ? `<a href="/services/${service}#logs" class="log-count warn clickable">${getLogIcon("warn")} ${stats.logs.warn}</a>` : ""}
${stats.logs.info > 0 ? `<a href="/services/${service}#logs" class="log-count info clickable">${getLogIcon("info")} ${stats.logs.info}</a>` : ""}
</div>
`
: '<div class="service-logs"><span class="no-logs">No messages</span></div>'
}
</div>`;
})
.join("")}
</div>
<br><br>
Expand Down
107 changes: 104 additions & 3 deletions src/views/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,20 @@ export const renderServiceTools = (data: ServiceToolsData): string => {
? Object.entries(logGroups)
.map(([key, group]) => {
const [severity, message] = key.split(":", 2);
// Create a hash-friendly ID for this log group
const logId = `log-${severity.toLowerCase()}-${message
.replace(/[^a-zA-Z0-9]/g, "-")
.replace(/-+/g, "-")
.replace(/^-|-$/g, "")}`;
return `
<div class="log-group">
<div class="log-group" id="${logId}">
<div class="log-header">
<span class="log-icon ${severity.toLowerCase()}">${getLogIcon(severity.toLowerCase())}</span>
<span class="log-message">${message}</span>
<span class="log-count">${group.tools.length} tool${group.tools.length !== 1 ? "s" : ""}</span>
<button class="share-link-btn" onclick="copyShareLink('${logId}')" title="Copy share link">
<span class="share-icon">🔗</span>
</button>
</div>
<div class="log-tools">
${group.tools
Expand Down Expand Up @@ -378,6 +386,29 @@ export const renderServiceTools = (data: ServiceToolsData): string => {
align-items: center;
gap: 12px;
}
.share-link-btn {
background: none;
border: 1px solid #dee2e6;
border-radius: 4px;
padding: 4px 8px;
cursor: pointer;
transition: all 0.2s ease;
margin-left: auto;
}
.share-link-btn:hover {
background-color: #e9ecef;
border-color: #adb5bd;
}
.share-icon {
font-size: 14px;
}
.log-group.highlighted {
border: 2px solid #007acc;
background-color: #f8f9ff;
}
.log-group.highlighted .log-header {
background-color: #e6f3ff;
}
.log-icon {
font-size: 16px;
}
Expand Down Expand Up @@ -502,9 +533,79 @@ export const renderServiceTools = (data: ServiceToolsData): string => {
document.getElementById(tabName + '-tab').classList.add('active');
}

// Show tools tab by default when page loads
// Copy share link to clipboard
function copyShareLink(logId) {
const url = window.location.origin + window.location.pathname + '#' + logId;
navigator.clipboard.writeText(url).then(function() {
// Show temporary feedback
const button = event.target.closest('.share-link-btn');
const originalText = button.innerHTML;
button.innerHTML = '<span style="color: green;">✓ Copied!</span>';
setTimeout(() => {
button.innerHTML = originalText;
}, 2000);
}).catch(function() {
// Fallback for older browsers
const textArea = document.createElement('textarea');
textArea.value = url;
document.body.appendChild(textArea);
textArea.select();
document.execCommand('copy');
document.body.removeChild(textArea);

const button = event.target.closest('.share-link-btn');
const originalText = button.innerHTML;
button.innerHTML = '<span style="color: green;">✓ Copied!</span>';
setTimeout(() => {
button.innerHTML = originalText;
}, 2000);
});
}

// Handle URL hash on page load and hash changes
function handleHash() {
const hash = window.location.hash.substring(1);
if (hash && hash.startsWith('log-')) {
// Switch to logs tab
showTab('logs');

// Remove highlighting from all log groups
document.querySelectorAll('.log-group').forEach(group => {
group.classList.remove('highlighted');
});

// Highlight the targeted log group
const targetElement = document.getElementById(hash);
if (targetElement) {
targetElement.classList.add('highlighted');
// Scroll to the element after a short delay to ensure tab content is visible
setTimeout(() => {
targetElement.scrollIntoView({ behavior: 'smooth', block: 'center' });
}, 100);
}
}
}

// Show tools tab by default when page loads, unless there's a hash
document.addEventListener('DOMContentLoaded', function() {
showTab('tools');
const hash = window.location.hash;
if (hash && hash.startsWith('#log-')) {
handleHash();
} else if (hash === '#logs') {
showTab('logs');
} else {
showTab('tools');
}
});

// Handle hash changes (when user clicks browser back/forward or manually changes hash)
window.addEventListener('hashchange', function() {
const hash = window.location.hash;
if (hash && hash.startsWith('#log-')) {
handleHash();
} else if (hash === '#logs') {
showTab('logs');
}
});
</script>
</head>
Expand Down