Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing syntax for 1.8.4, sub-task | session profile | #92

Conversation

ipruteanu-sie
Copy link
Contributor

Overall Review of Changes:
Fixing syntax issues identified for 1.8.4, sub-task | session profile.
Issue Fixes:
#91

Enhancements:
N/A

How has this been tested?:
Manually, via CIS(nix_gdm_screen_lock_chk.sh), as this failure:

- Audit Result:
  ** FAIL **
 - Reason(s) for audit failure:

 - The "local" doesn't exist.


- Correctly set:

 - The "idle-delay" option is set to "900" seconds in "/etc/dconf/db/local.d/00-screensaver"
 - The "lock-delay" option is set to "5" seconds in "/etc/dconf/db/local.d/00-screensaver"
 - The "local" profile exists in the dconf database

changed to a pass:

- Audit Result:
  ** PASS **

 - The "idle-delay" option is set to "900" seconds in "/etc/dconf/db/local.d/00-screensaver"
 - The "lock-delay" option is set to "5" seconds in "/etc/dconf/db/local.d/00-screensaver"
 - The "local" profile exists
 - The "local" profile exists in the dconf database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and fix, have noticed that there are two indent spaces, we are marked on yamllint on ansible-galaxy and we have set this to 4. If you could move this to 4 happy to accept the PR
thanks

uk-bolly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed that, thanks for your quick response!

…ith Ansible-Galaxy linting requirements

Signed-off-by: Ionut Pruteanu <[email protected]>
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and fix

@uk-bolly uk-bolly merged commit b15ee75 into ansible-lockdown:devel Sep 22, 2023
@uk-bolly uk-bolly mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants