Blacklist USB-Storage to pass CIS scan #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
|
hi @rspataru Thank you for taking the time to raise this PR, Great catch and happy to add unfortunately we do need to have it signed off and signed for every commit. Many thanks once again uk-bolly |
uk-bolly
added a commit
that referenced
this pull request
Aug 10, 2023
Signed-off-by: Mark Bolwell <[email protected]>
|
hi @rspataru Thank you once again for raising this and providing the fix. thank you again uk-bolly |
Merged
|
Hi! No worries, i saw some other fixes that need to be made. When i have
some free time I will create some PR's. Have a good day!
…On Thu, Aug 10, 2023 at 10:44 AM uk-bolly ***@***.***> wrote:
hi @rspataru <https://github.com/rspataru>
Thank you once again for raising this and providing the fix.
I have added this fix into the latest updates (will be in devel and main
later today) and credits are given for your work.
thank you again
uk-bolly
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3VRSGGKC3NHSE2H63LDP3TXUSGPBANCNFSM6AAAAAA2PS25HU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Radu Spataru
Associate DevOps Engineer
[image: 8x8.com logo] <https://www.8x8.com/>
*One platform. Every communications experience.*
Learn more → <https://www.8x8.com/>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Blacklisted usb-storage in /etc/modprobe.d/blacklist.conf
Issue Fixes:
Using the CIS Benchmark we can see that this rule will fail because it was not blacklisted. Now the scan will pass
Enhancements:
How has this been tested?:
Using ansible